This repository was archived by the owner on Jan 13, 2024. It is now read-only.
Repository navigation
This repository was archived by the owner on Jan 13, 2024. It is now read-only.
Executable broken when called with PKG_EXECPATH set to its own absolute path #1565
Description
What version of pkg are you using?
5.5.2
What version of Node.js are you using?
16.14.0
What operating system are you using?
Ubuntu 20.04
What CPU architecture are you using?
x86_64
What Node versions, OSs and CPU architectures are you building for?
node16-linux-x64
Describe the Bug
Calling an executable created with pkg with the PKG_EXECPATH environment variable set to the absolute path of the executable produces an error.
Expected Behavior
Setting the PKG_EXECPATH environment variable to the absolute path of the executable should not produce any error:
$ tee test.js <<< "console.log('test');"
console.log('test');
$ pkg test.js --target=node16-linux-x64 --output=test
pkg@5.5.2
$ ./test
test
$ PKG_EXECPATH=$(realpath test) ./test
test
$ PKG_EXECPATH=$(realpath test) ./test argument
testTo Reproduce
Setting the PKG_EXECPATH environment variable to the absolute path of the executable produces an error:
$ tee test.js <<< "console.log('test');"
console.log('test');
$ pkg test.js --target=node16-linux-x64 --output=test
pkg@5.5.2
$ ./test
test
$ PKG_EXECPATH=$(realpath test) ./test
pkg/prelude/bootstrap.js:1813
if (error.code !== 'MODULE_NOT_FOUND') throw error;
^
TypeError: String.prototype.startsWith called on null or undefined
at startsWith (<anonymous>)
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:849:7)
at Function._resolveFilename (pkg/prelude/bootstrap.js:1811:44)
at Function.Module._load (node:internal/modules/cjs/loader:778:27)
at Function.runMain (pkg/prelude/bootstrap.js:1847:12)
at node:internal/main/run_main_module:17:47
$ PKG_EXECPATH=$(realpath test) ./test argument
node:internal/modules/cjs/loader:936
throw err;
^
Error: Cannot find module '/path/to/current/directory/argument'
at Function.Module._resolveFilename (node:internal/modules/cjs/loader:933:15)
at Function._resolveFilename (pkg/prelude/bootstrap.js:1819:46)
at Function.Module._load (node:internal/modules/cjs/loader:778:27)
at Function.runMain (pkg/prelude/bootstrap.js:1847:12)
at node:internal/main/run_main_module:17:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
Activity
0x2b3bfa0 commentedon Mar 24, 2022
Related Issues
0x2b3bfa0 commentedon Mar 24, 2022
Explanation
pkg/prelude/bootstrap.js
Lines 77 to 89 in 2ef4cd9
TypeError: String.prototype.startsWith called on null or undefinedtrue(executable called withPKG_EXECPATHset to its own absolute path)false(executable called without arguments, or the first argument is a hyphen)process.argv[1]remainsundefinedbecause no other assignment is being madeENTRYPOINTbecomesprocess.argv[1]at line 88Error: Cannot find module '/path/to/current/directory/argument'true(executable called withPKG_EXECPATHset to its own absolute path)true(executable called with one or more arguments, and the first argument isn't a hyphen)process.argv[1]becomespath.resolve(process.argv[1])1ENTRYPOINTbecomesprocess.argv[1]at line 88pkg/prelude/bootstrap.js
Line 1846 in 2ef4cd9
Value of
ENTRYPOINT(eitherundefinedor a non–existent path) is used to call the_loadfunction, producing an error.Footnotes
Namely,
'/path/to/current/directory/argument'↩0x2b3bfa0 commentedon Mar 24, 2022
It turns out that there aren't other solutions apart from unsetting
PKG_EXECPATHas proposed on #897. At least, I haven't found any.