Skip to content

LayoutWriter doesn't respect validity of the top level Struct array #710

Closed

Description

@robert3005

Right now if StructArray has top level validity that's not AllValid or NonNullable the validity is discarded

Activity

  1. doki23 commented on Oct 7, 2024

    @doki23
    Contributor

    Could you please provide more details? I'm interested in this issue and would like to attempt to resolve it.

  2. robert3005 commented on Oct 15, 2024

    @robert3005
    ContributorAuthor

    This is likely not a good first issue. The solution here is likely to either forbid writing top level structs with validity other than nonnullable and provide a function to push validity of the struct to the children, i.e. run a filter. Alternatively we need to teach column layout about one extra validity array which shouldn't be bad but likely unnecessary

  3. gatesn commented on Apr 14, 2025

    @gatesn
    Contributor

    In the current format, isn't it true that this is actually any struct array? I'd like to at least known the fix here to make sure it's not a breaking change when we do.

  4. added this to the V0 milestone on Apr 14, 2025
  5. gatesn commented on May 29, 2025

    @gatesn
    Contributor

    We should assert at write-time that struct arrays have Validity::NonNullable or Validity::AllValid

  6. added a commit that references this issue on Jun 2, 2025
    31177e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions