Repository navigation
Fix setup and add configuration management for the web assistant - #411
Conversation
|
To preview the documentation for this pull request, visit the following URL:
|
Bugbot: review complete
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #411 +/- ##
===========================================
+ Coverage 90.94% 92.50% +1.56%
===========================================
Files 135 826 +691
Lines 6251 24987 +18736
Branches 1338 7086 +5748
===========================================
+ Hits 5685 23115 +17430
- Misses 172 786 +614
- Partials 394 1086 +692
🚀 New features to boost your workflow:
|
…ter permission audit
…sions before token creation
… PAT uses the wrong account
…r storage conflicts
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on514ed4d. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit 411e286 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- medium: Preservation is disabled for any resource named PAT —
src/application/policies/setup_configuration_storage_policy.ts:37
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on514ed4d. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit 47fb66e was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- low: Latest runs page can hide all recent pull-request checks —
src/infrastructure/github_setup_approval_check_discovery_adapter.ts:44
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on514ed4d. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit c158cbd was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- medium: Mixed variable write errors can be silently dropped —
src/application/usecases/actions/setup_resource_provisioning.ts:233
…on and management handoff
…etain complete Variable errors
Setup could reject valid PATs, lose progress after a bot-account mistake, miss recent CI producers, or fail installation on issue context and moving Action tags. The web assistant now also opens a configuration panel before the complete wizard: it explains this checkout, reads effective GitHub settings, and supports reviewed changes to independent parameters.
Validation: 557 suites passed; 6,833 tests passed and 26 skipped. All coverage budgets passed. Each of the seven new management runtime modules has 100% statements, branches, functions and lines. All 612 added/changed executable source lines are covered locally, with zero partially covered changed branches. The added management cases exceed the SDD's 96-case minimum; the existing web acceptance ledger remains 308/350 passed with 42 explicitly open human/provider cases. Typecheck, lint, Svelte/Vite, specification/catalog/documentation/workflow checks, synchronized build and the 69-file package contract passed. Packaged CLI/API/web smoke uses disposable local fixtures. The final commit hook passed the full suite and lint with two Jest workers.
User-authorized live dogfooding from the installed package verified organization quick-change/readback/restoration cycles for review comment limits and PR reviewer count, cancelled previews and no-op changes. A prior complete installation succeeded with organization Secrets/Variables, SDDs, inactive issue closure, CI Check + RepoWise, Project #2, bot vypbot and omitted Codex API key. A repeated overwrite attempt correctly stopped before Apply because five existing repository AGENT_* Variables shadow organization values; the conflicting repository Variables were left intact. A preserving-variable repetition also completed successfully, including bot Actions/Project cleanup and an omitted Codex API key. The new package verified an additional comment-limit cycle 20 → 19 → 20. Read-only Finish now completes without requiring an installation mutation; a full-assistant handoff preserves prior quick changes without masking a later uncertain installer write. Prior read-only doctor results were 100 pass / 5 warn / 5 fail, including branch-rule/native-approval readiness; these are not claimed as resolved installation failures. Existing Secrets cannot be rolled back because GitHub does not reveal their old values.
Every generated dogfooding configuration file is archived outside the repository, inspected and discarded. This PR changes no files under .github or .copilot, preserving the repository's product baseline. CI and all three hosted platform smoke jobs passed on 514ed4d. Codecov confirms that all modified and coverable lines are covered on this exact head; local diff coverage also has zero partially covered changed branches. Conditional self-hosted and hosted Windows coverage-upload jobs were skipped. Codecov warns that its base coverage report is stale (1,069 commits behind), so the project coverage delta is not used as evidence of develop readiness. RepoWise local analysis found no critical refactoring findings in the three new refactored modules; repository-wide health is 9.11/10 and hotspot health 10/10, with existing legacy findings retained. The RepoWise CI health report succeeded on 514ed4d. Its optional dead-code scan timed out (exit 124), and its security/history scan failed with MemoryError (exit 1). These advisory scans are explicitly incomplete; they are not asserted as a completed dead-code or security review. The existing repository workflow is unchanged.