Skip to content

[#482] 🐛 - Dogfooding progress cards remain active after native issue closure - #483

Merged
efraespada merged 6 commits into
developfrom
bugfix/482-dogfooding-progress-cards-remain-active-after-native-issue-closure
Oct 13, 2026
Merged

efraespada merged 6 commits into
developfrom
bugfix/482-dogfooding-progress-cards-remain-active-after-native-issue-closure

Conversation

@efraespada

@efraespada efraespada commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Closing an issue currently leaves its progress card showing active implementation work. This change archives the same bot-owned card as history and fences late progress jobs against the live issue state, while preserving the reported estimate and the native closure reason.

Validation: local coverage and normal hooks passed 608 suites, 8,641 tests and 35 skipped. The Action-managed Ubuntu synchronization then passed 608 suites, 8,649 tests and 35 skipped after integrating the eight Doctor cases, and completed all six configured checks. The progress capability has 89 runtime cases and 45 budget declarations. Coverage, typecheck, build, lint, documentation and specification validation and normal repository commit hooks passed.

The current review found that escaped archive output could exceed the publication limit. Six regression cases now verify final output length, safe replay and the no-update path. Oversized output leaves the existing card unchanged.

Native merged closure, manual closure, replay and reopening will be checked after promotion.

Closes #482

@docs-page

docs-page Bot commented Oct 13, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~483

Documentation is deployed and generated using docs.page

@vypbot vypbot changed the title [#482] Retire progress cards after native issue closure [#482] 🐛 - Dogfooding progress cards remain active after native issue closure Oct 13, 2026
@vypbot vypbot added the 85% Progress: 85% label Oct 13, 2026
@vypbot
vypbot self-requested a review October 13, 2026 11:11
@vypbot vypbot moved this to In Progress in vypdev Oct 13, 2026
@vypbot vypbot added this to vypdev Oct 13, 2026
@vypbot
vypbot changed the base branch from develop to master October 13, 2026 11:11
@efraespada efraespada linked an issue Oct 13, 2026 that may be closed by this pull request
1 task done
@vypbot
vypbot changed the base branch from master to develop October 13, 2026 11:12
@vypbot vypbot added the size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. label Oct 13, 2026
@vypbot

vypbot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on e462afe.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: e462afe5ff7e; base: c485de3de659; reason: protected-path.

@codecov-commenter

codecov-commenter commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.29630% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.10%. Comparing base (c485de3) to head (e462afe).

Files with missing lines Patch % Lines
...ation/usecases/actions/retire_progress_use_case.ts 93.18% 0 Missing and 3 partials ⚠️
...s/steps/common/status_card_publication_workflow.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #483      +/-   ##
===========================================
+ Coverage    93.09%   93.10%   +0.01%     
===========================================
  Files          869      872       +3     
  Lines        26997    27101     +104     
  Branches      7810     7846      +36     
===========================================
+ Hits         25132    25233     +101     
  Misses         746      746              
- Partials      1119     1122       +3     
Files with missing lines Coverage Δ
src/actions/github_action.ts 95.49% <100.00%> (+0.04%) ⬆️
...n/policies/retired_progress_presentation_policy.ts 100.00% <100.00%> (ø)
...cation/usecases/actions/check_progress_workflow.ts 95.91% <100.00%> (+2.44%) ⬆️
...ases/actions/retire_closed_issue_cards_use_case.ts 100.00% <100.00%> (ø)
...ure/composition/check_progress_composition_root.ts 95.65% <100.00%> (+0.19%) ⬆️
...ure/composition/main_run_route_composition_root.ts 92.08% <100.00%> (+0.29%) ⬆️
...position/pull_request_use_case_composition_root.ts 100.00% <100.00%> (ø)
...ture/composition/shared_capability_port_binding.ts 100.00% <100.00%> (ø)
...s/steps/common/status_card_publication_workflow.ts 96.82% <75.00%> (-1.51%) ⬇️
...ation/usecases/actions/retire_progress_use_case.ts 93.18% <93.18%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada

efraespada commented Oct 13, 2026 •

Copy link
Copy Markdown
Member Author

/copilot doctor

@efraespada

Copy link
Copy Markdown
Member Author

/copilot sync-branch

@vypbot

vypbot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

🩺 Diagnóstico del runtime: No disponible

Algunos requisitos no se pudieron verificar; las comprobaciones completadas siguen visibles.

Siguiente acción: Revisa esta ejecución del workflow y vuelve a ejecutar /copilot doctor.

Este comando solo lee evidencias. La configuración de aprobación declarada no acredita la salud de los productores ni el acceso de escritura.

Comprobaciones

  • Configuración efectiva: Correcto
  • Requisitos de la issue y el SDD: No aplicable
  • Rama enlazada nativa: No aplicable
  • Estructura de los workflows instalados: No disponible
  • Lectura confiable de la política de aprobación: Correcto · Variable del repositorio
  • Requisitos de aprobación declarados: Advertencia · Modo: recommend
  • Identidad actual exacta del PR: Correcto · PR inspeccionado

Revisión inspeccionada del repositorio

@vypbot

vypbot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Branch synchronized

develop was merged into bugfix/482-dogfooding-progress-cards-remain-active-after-native-issue-closure and pushed as fb30b0660c97c165e63591eab8e94c95f814c207.

The fixer resolved 1 conflicted file.

6 verification checks passed.

@efraespada

Copy link
Copy Markdown
Member Author

/copilot recheck

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on e462afe. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 0169920 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • medium: Progress status publication lacks the required native issue-state query — src/application/usecases/steps/common/status_card_publication_workflow.ts:106

@efraespada

Copy link
Copy Markdown
Member Author

/copilot dismiss "status_card_publication_workflow.ts:106:missing-native-state-query"

@vypbot

vypbot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

1 finding was dismissed.

@efraespada

Copy link
Copy Markdown
Member Author

/copilot sync-branch

@vypbot vypbot added state:ai-processing 85% Progress: 85% and removed 90% Progress: 90% labels Oct 13, 2026
@vypbot

vypbot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Rama sincronizada

develop se integró en bugfix/482-dogfooding-progress-cards-remain-active-after-native-issue-closure y se envió como e462afe5ff7ee55671a27f0ae2aaf6c71ad8f248.

El agente de corrección resolvió 1 archivo con conflictos.

Se superaron 6 comprobaciones de verificación.

@efraespada

Copy link
Copy Markdown
Member Author

/copilot recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

85% Progress: 85% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Dogfooding progress cards remain active after native issue closure

3 participants