Skip to content

[#541] 🐛 - bug pre branch SDD drafting fails after successful analysis with an unclassified agent exit - #542

Merged
efraespada merged 2 commits into
developfrom
bugfix/541-bug-pre-branch-sdd-drafting-fails-after-successful-analysis-with-an-unclassified-agent-exit
Oct 17, 2026
Merged

efraespada merged 2 commits into
developfrom
bugfix/541-bug-pre-branch-sdd-drafting-fails-after-successful-analysis-with-an-unclassified-agent-exit

Conversation

@efraespada

@efraespada efraespada commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Complex pre-branch SDD requests could stop before branch creation with an incomplete provider response (max_output_tokens). The initial stderr window hid the terminal reason behind the echoed prompt, so the Action reported only an unclassified agent failure.

The Codex policy now sends a compatible closed native JSON schema while preserving every string-length constraint in the original local acceptance schema. Required fields, nullable shapes, enums and numeric/array constraints remain native; accepted SDDs still pass the original full local schema, content/catalog writer and freshness checks. Draft prompts prefer a compact complete document. Failed-process diagnostics inspect a bounded terminal stderr window and publish only the fixed reported-output-token-limit hint. Provider choice, credentials, process limits, retry policy and publication gates are unchanged.

Validation:

  • Reproduced ✨🧑‍💻 - feat reuse organization configuration and set up selected repositories in one guided session #538 using the real public draft prompt and official codex-cli 0.163.0; the original native artifact failed with the terminal output-token-limit reason. Reducing the preferred length alone reproduced the failure.
  • With the corrected production policy, the same configured provider/model completed valid JSON; the 43,878-character SDD passed its original local length schema and the real temporary-worktree SDD/catalog writer. The probe published no branch, commit or document for ✨🧑‍💻 - feat reuse organization configuration and set up selected repositories in one guided session #538.
  • Full coverage: 631 suites / 9,459 passing tests; 35 existing skips. All coverage and setup-acceptance budgets passed; the new pure projection policy is covered at 100% in all metrics.
  • Native compatibility, local min/max enforcement, terminal diagnostic classification, split/large/evicted stderr data, privacy and real-child cleanup regressions pass.
  • The first extended Windows coverage run exposed a pre-existing 5-second timeout in the Actions permission probe integration fixture (43 cases). Only that fixture receives a finite 20-second Windows budget so its real disk-synchronized journal and cleanup can finish; production deadlines and all assertions remain unchanged. All 43 cases pass locally. On final head b16f55e, CI Check and Bugbot pass, and hosted Linux, macOS and Windows package/session/full-coverage gates all pass. RepoWise also passes; every executed check is green on the final head. The automatic Copilot approval remains neutral for a protected policy path, with explicit maintainer merge authorization recorded in this session.
  • Build/bundle parity, typecheck, lint, specification/catalog, workflow/documentation and npm-package validators plus packaged CLI/API/local web smoke passed. Graphify AST updated.

Closes #541. Unblocks the runtime prerequisite for #538; the live issue must be rerun after the reviewed Action version reaches its workflow source. This PR does not implement organization reuse or multi-repository setup.

…s-with-an-unclassified-agent-exit: complete SDD drafts with compatible Codex schemas
@docs-page

docs-page Bot commented Oct 17, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~542

Documentation is deployed and generated using docs.page

@vypbot vypbot added size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:ai-processing labels Oct 17, 2026
@vypbot vypbot changed the title fix: complete SDD drafts with compatible Codex schemas [#541] 🐛 - bug pre branch SDD drafting fails after successful analysis with an unclassified agent exit Oct 17, 2026
@vypbot
vypbot self-requested a review October 17, 2026 12:33
@vypbot vypbot added the 75% Progress: 75% label Oct 17, 2026
@vypbot vypbot added this to vypdev Oct 17, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 17, 2026
@vypbot
vypbot changed the base branch from develop to master October 17, 2026 12:33
@vypbot
vypbot changed the base branch from master to develop October 17, 2026 12:34
@vypbot

vypbot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on b16f55e.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: b16f55e46394; base: c6a69669aa99; reason: protected-path.

@codecov-commenter

codecov-commenter commented Oct 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.38%. Comparing base (274db40) to head (b16f55e).
⚠️ Report is 1445 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #542      +/-   ##
===========================================
+ Coverage    90.94%   93.38%   +2.43%     
===========================================
  Files          135      897     +762     
  Lines         6251    27930   +21679     
  Branches      1338     8126    +6788     
===========================================
+ Hits          5685    26082   +20397     
- Misses         172      733     +561     
- Partials       394     1115     +721     
Files with missing lines Coverage Δ
...ies/agent_execution/codex_execution_plan_policy.ts 100.00% <100.00%> (ø)
...cies/agent_execution/codex_output_schema_policy.ts 100.00% <100.00%> (ø)
...ication/ports/agent_execution_observation_ports.ts 100.00% <ø> (ø)
...tion/usecases/sdd/pre_branch_sdd_draft_workflow.ts 100.00% <100.00%> (ø)
src/data/repository/agent_cli_execution.ts 94.81% <100.00%> (ø)
src/data/repository/agent_cli_exit_diagnostic.ts 100.00% <100.00%> (ø)

... and 958 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…s-with-an-unclassified-agent-exit: bound Windows journal fixture cleanup time
@efraespada
efraespada merged commit 95d64ff into develop Oct 17, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

75% Progress: 75% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - bug pre branch SDD drafting fails after successful analysis with an unclassified agent exit

3 participants