Skip to content

[#610] 🐛 - Private pull request linkage inspection ignores authentication and fails with HTTP 404 - #612

Merged
efraespada merged 2 commits into
developfrom
bugfix/610-private-pull-request-linkage-inspection-ignores-authentication-and-fails-with-http-404
Oct 20, 2026
Merged

efraespada merged 2 commits into
developfrom
bugfix/610-private-pull-request-linkage-inspection-ignores-authentication-and-fails-with-http-404

Conversation

@efraespada

@efraespada efraespada commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Pull request linkage checks now use the configured GitHub credential, so private PRs can be inspected without anonymous HTML 404s. The check confirms the exact repository, PR, and intended issue before treating linkage as complete.

What changed

  • Replaced anonymous HTML inspection with authenticated GraphQL lookup of closing issue references.
  • Require an exact repository, pull request, and issue match; incomplete or malformed results fail closed within a two-page, 200-reference limit.
  • Map authorization, not-found, rate-limit, unsupported-client, and provider errors to distinct diagnostics while preserving lifecycle compensation.
  • Documented linkage behavior and troubleshooting guidance.

Validation

  • 73 focused lifecycle, linkage, and credential-binding tests passed.
  • Full repository tests, build, and lint passed through the required commit hooks.
  • Typecheck, specification, documentation, generated bundle, and npm package checks passed.
  • An authenticated read-only query was verified against the live GitHub schema.

Closes #610

…tion-and-fails-with-http-404: authenticate exact pull request issue linkage (#610)
@docs-page

docs-page Bot commented Oct 20, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~612

Documentation is deployed and generated using docs.page

@vypbot vypbot added size: XL Indicates that the issue or task is extra large in scope and complexity. 90% Progress: 90% labels Oct 20, 2026
@codecov-commenter

codecov-commenter commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.06%. Comparing base (274db40) to head (70196f4).
⚠️ Report is 1521 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #612      +/-   ##
===========================================
+ Coverage    90.94%   94.06%   +3.12%     
===========================================
  Files          135      937     +802     
  Lines         6251    30224   +23973     
  Branches      1338     8860    +7522     
===========================================
+ Hits          5685    28431   +22746     
- Misses         172      704     +532     
- Partials       394     1089     +695     
Files with missing lines Coverage Δ
...s/pull_request/link_pull_request_issue_workflow.ts 100.00% <100.00%> (ø)
.../pull_request/pull_request_lifecycle_repository.ts 86.48% <100.00%> (ø)
...e/composition/lifecycle_capability_port_binding.ts 96.92% <100.00%> (ø)

... and 1001 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vypbot vypbot changed the title fix: authenticate exact pull request issue linkage [#610] 🐛 - Private pull request linkage inspection ignores authentication and fails with HTTP 404 Oct 20, 2026
@vypbot
vypbot self-requested a review October 20, 2026 09:50
@vypbot vypbot added this to vypdev Oct 20, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 20, 2026
@vypbot
vypbot changed the base branch from develop to master October 20, 2026 09:50
@vypbot
vypbot changed the base branch from master to develop October 20, 2026 09:50

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on 70196f4. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 994035d was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • low: GraphQL UNAUTHORIZED errors are reported as retryable outages — src/data/repository/pull_request/pull_request_lifecycle_repository.ts:178

@vypbot

vypbot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 70196f4.

Pull request · Verified commit · Workflow run

…tion-and-fails-with-http-404: classify GraphQL unauthorized linkage as terminal access failure
@vypbot

vypbot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 70196f45b9f6; base: 3d30ac0394e9; reason: protected-path.

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on 70196f4. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 70196f4 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • medium: Manual issue links are not detected — src/data/repository/pull_request/pull_request_lifecycle_repository.ts:142

@vypbot

vypbot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

1 finding was dismissed.

@efraespada

Copy link
Copy Markdown
Member Author

/copilot recheck

@efraespada
efraespada merged commit ae2bd2d into develop Oct 20, 2026
24 of 25 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

90% Progress: 90% size: XL Indicates that the issue or task is extra large in scope and complexity. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Private pull request linkage inspection ignores authentication and fails with HTTP 404

3 participants