Skip to content

[#611] 🐛 - Missing pnpm lockfile comparison patch is reported as a retryable provider outage - #613

Merged
efraespada merged 2 commits into
developfrom
bugfix/611-missing-pnpm-lockfile-comparison-patch-is-reported-as-a-retryable-provider-outage
Oct 20, 2026
Merged

efraespada merged 2 commits into
developfrom
bugfix/611-missing-pnpm-lockfile-comparison-patch-is-reported-as-a-retryable-provider-outage

Conversation

@efraespada

@efraespada efraespada commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Missing patches in pinned progress comparisons now produce a nonretryable evidence-unavailable result instead of a retryable provider outage. This keeps incomplete comparisons from being assessed while preserving existing progress and providing a maintainer recovery path.

What changed

  • Classify omitted required source patches, including pnpm lockfiles and content-unproven binary or rename changes, as validation.evidence-unavailable.
  • Preserve progress and published assessments and make no model call when required evidence is missing; genuine transport failures remain retryable.
  • Document the exact-comparison review and smaller-change recovery path, with English and Spanish error messages.
  • Keep generated build and catalog exceptions limited to metadata; they do not certify file contents or completion.

Validation

  • 171 focused adapter, use-case, error-contract, and English/Spanish presentation tests passed.
  • Typecheck, lint, specification checks, and documentation checks passed.
  • Full repository hooks passed: 676 suites, 10,913 tests passed, and 35 configured skips; build and lint passed.
  • Generated bundle and npm package validation passed; packaged CLI, API, and local web smoke tests passed.

Closes #611

…tryable-provider-outage: distinguish omitted progress patches from provider outages (#611)
@docs-page

docs-page Bot commented Oct 20, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~613

Documentation is deployed and generated using docs.page

@vypbot vypbot added size: XL Indicates that the issue or task is extra large in scope and complexity. 90% Progress: 90% state:ai-processing labels Oct 20, 2026
@vypbot vypbot changed the title fix: report omitted progress patches as nonretryable evidence loss [#611] 🐛 - Missing pnpm lockfile comparison patch is reported as a retryable provider outage Oct 20, 2026
@vypbot
vypbot self-requested a review October 20, 2026 09:57
@vypbot vypbot added this to vypdev Oct 20, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 20, 2026
@vypbot
vypbot changed the base branch from develop to master October 20, 2026 09:57
@codecov-commenter

codecov-commenter commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.06%. Comparing base (274db40) to head (a3699ab).
⚠️ Report is 1524 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #613      +/-   ##
===========================================
+ Coverage    90.94%   94.06%   +3.12%     
===========================================
  Files          135      937     +802     
  Lines         6251    30226   +23975     
  Branches      1338     8861    +7523     
===========================================
+ Hits          5685    28433   +22748     
- Misses         172      704     +532     
- Partials       394     1089     +695     
Files with missing lines Coverage Δ
...tion/policies/application_error_message_catalog.ts 100.00% <ø> (ø)
src/data/model/application_error.ts 100.00% <ø> (ø)
src/data/repository/progress_diff_repository.ts 100.00% <100.00%> (ø)

... and 1001 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vypbot
vypbot changed the base branch from master to develop October 20, 2026 09:57
@vypbot

vypbot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot unverified.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: a3699ab2fab9; base: ae2bd2df2bba; reason: protected-path.

@vypbot

vypbot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on efb4a57.

Pull request · Verified commit · Workflow run

@efraespada

Copy link
Copy Markdown
Member Author

/copilot sync-branch

@vypbot

vypbot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Branch synchronized

develop was merged into bugfix/611-missing-pnpm-lockfile-comparison-patch-is-reported-as-a-retryable-provider-outage and pushed as a3699ab2fab9da13f20b9db1a6a4b70b61d555ff.

6 verification checks passed.

@efraespada
efraespada merged commit 8a3ddcd into develop Oct 20, 2026
11 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

90% Progress: 90% size: XL Indicates that the issue or task is extra large in scope and complexity. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Missing pnpm lockfile comparison patch is reported as a retryable provider outage

3 participants