Skip to content

fix: preserve conventional pull request titles - #623

Merged
efraespada merged 1 commit into
developfrom
bugfix/621-pr-processing-overwrites-a-valid-conventional-title-and-breaks-semantic-title-ci
Oct 20, 2026
Merged

efraespada merged 1 commit into
developfrom
bugfix/621-pr-processing-overwrites-a-valid-conventional-title-and-breaks-semantic-title-ci

Conversation

@efraespada

@efraespada efraespada commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

PR processing now preserves an existing Conventional Commits title and generates a conventional title from a linked issue only when needed. This prevents automatic title updates from breaking consumer semantic-title checks.

What changed

  • Preserve the current PR title byte-for-byte when it has a conventional header, including contributor corrections visible after an older event was queued.
  • Generate bounded fix:, feat:, docs:, or chore: titles with a trailing issue reference when the current title needs updating.
  • Keep issue title formatting separate and document title precedence, configuration behavior, and the remaining concurrent-edit window.

Validation

  • 36 incremental policy, application, and adapter regression cases; full coverage run passed 679 suites and 10,990 tests (35 skipped), with 100% statement, function, and branch coverage for the new policy.
  • Typecheck, lint, documentation/routes/assets, workflow and specification validators, generated-bundle validation, and npm package contents passed.
  • Mandatory pre-commit build, full tests, and lint passed; Graphify updated.

Review notes

  • The live title read is not an atomic compare-and-swap; an edit made between the read and GitHub's update may still be overwritten.
  • Existing decorated PR titles are not bulk-migrated; a later title-processing event may generate the new format.

Closes #621

…eaks-semantic-title-ci: preserve conventional PR titles and generate compatible headers
@docs-page

docs-page Bot commented Oct 20, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~623

Documentation is deployed and generated using docs.page

@vypbot vypbot added size: XL Indicates that the issue or task is extra large in scope and complexity. 90% Progress: 90% state:ai-processing labels Oct 20, 2026
@vypbot
vypbot self-requested a review October 20, 2026 14:20
@vypbot vypbot added this to vypdev Oct 20, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 20, 2026
@vypbot
vypbot changed the base branch from develop to master October 20, 2026 14:20
@vypbot
vypbot changed the base branch from master to develop October 20, 2026 14:21
@vypbot

vypbot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on cc7fda2.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: cc7fda2a9c6f; base: 8604cff6d234; reason: protected-path.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.07%. Comparing base (274db40) to head (cc7fda2).
⚠️ Report is 1535 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #623      +/-   ##
===========================================
+ Coverage    90.94%   94.07%   +3.12%     
===========================================
  Files          135      939     +804     
  Lines         6251    30255   +24004     
  Branches      1338     8875    +7537     
===========================================
+ Hits          5685    28462   +22777     
- Misses         172      704     +532     
- Partials       394     1089     +695     
Files with missing lines Coverage Δ
.../application/policies/pull_request_title_policy.ts 100.00% <100.00%> (ø)
...ion/usecases/steps/common/update_title_workflow.ts 100.00% <100.00%> (ø)
...rc/data/repository/issue/issue_title_repository.ts 100.00% <100.00%> (ø)

... and 1003 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada
efraespada merged commit 19408f7 into develop Oct 20, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

90% Progress: 90% size: XL Indicates that the issue or task is extra large in scope and complexity. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - PR processing overwrites a valid conventional title and breaks semantic title CI

3 participants