Skip to content

fix: expose causal approval evidence failures - #628

Merged
efraespada merged 3 commits into
developfrom
bugfix/619-approval-observer-hides-evidence-read-failures-behind-evidence-unavailable-without-actionable-diagnostics
Oct 20, 2026
Merged

efraespada merged 3 commits into
developfrom
bugfix/619-approval-observer-hides-evidence-read-failures-behind-evidence-unavailable-without-actionable-diagnostics

Conversation

@efraespada

@efraespada efraespada commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Approval observers now retain a sanitized operation, cause and access category when evidence reads fail. Permanent authorization/resource/schema errors and transient provider failures keep their retryability and correlation through the Job Summary and final Action error, while missing evidence continues to block approval.

What changed

  • Identify failing PR/ref, inventory, rule, job and coverage-artifact reads without exposing provider text, credentials or policy values.
  • Preserve independent evidence and block submission when initial or final evidence verification fails, including policy rereads; retain causal post-submit readback failures without repeating review POSTs.
  • Update recovery documentation, specification/catalog evidence and generated bundles.

Validation

  • Full coverage: 684 suites, 11,114 passed, 35 configured skips; all coverage budgets passed.
  • Types, lint, documentation/workflow/specification validators, generated bundle/package validation and Graphify passed.
  • Normal commit hooks passed build, the full test suite and lint.

The original consumer endpoint cause still needs a fresh observer run after promotion; this change makes that cause observable without changing approval policy or token permissions.

Closes #619

…ence-unavailable-without-actionable-diagnostics: retain causal approval evidence diagnostics
@docs-page

docs-page Bot commented Oct 20, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~628

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review October 20, 2026 17:58
@vypbot vypbot added this to vypdev Oct 20, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 20, 2026
@vypbot
vypbot changed the base branch from develop to master October 20, 2026 17:58
@vypbot
vypbot changed the base branch from master to develop October 20, 2026 17:58
@vypbot

vypbot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 74f6765.

Pull request · Verified commit · Workflow run

@vypbot vypbot added state:blocked state:awaiting-maintainer size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. 85% Progress: 85% and removed state:ai-processing labels Oct 20, 2026
@vypbot

vypbot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot unverified.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 732f12d07804; base: 7be4226d6579; reason: protected-path.

@codecov-commenter

codecov-commenter commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.43697% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.08%. Comparing base (274db40) to head (732f12d).
⚠️ Report is 1545 commits behind head on develop.

Files with missing lines Patch % Lines
...y/pull_request/pull_request_approval_repository.ts 86.27% 2 Missing and 5 partials ⚠️
...approval/observe_pull_request_approval_use_case.ts 95.23% 0 Missing and 1 partial ⚠️
.../repository/pull_request/approval_evidence_read.ts 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #628      +/-   ##
===========================================
+ Coverage    90.94%   94.08%   +3.13%     
===========================================
  Files          135      945     +810     
  Lines         6251    30443   +24192     
  Branches      1338     8946    +7608     
===========================================
+ Hits          5685    28642   +22957     
- Misses         172      704     +532     
- Partials       394     1097     +703     
Files with missing lines Coverage Δ
src/actions/pull_request_approval_action.ts 87.77% <100.00%> (ø)
src/application/errors/approval_evidence_error.ts 100.00% <100.00%> (ø)
...tion/policies/application_error_message_catalog.ts 100.00% <ø> (ø)
src/data/model/application_error.ts 100.00% <100.00%> (ø)
...sitory/pull_request/current_base_revision_query.ts 100.00% <100.00%> (ø)
src/domain/approval_evidence_diagnostic.ts 100.00% <100.00%> (ø)
src/domain/pull_request_approval.ts 97.93% <ø> (ø)
...approval/observe_pull_request_approval_use_case.ts 89.85% <95.23%> (ø)
.../repository/pull_request/approval_evidence_read.ts 93.75% <93.75%> (ø)
...y/pull_request/pull_request_approval_repository.ts 89.90% <86.27%> (ø)

... and 1002 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ence-unavailable-without-actionable-diagnostics: preserve final approval evidence failure causes
@efraespada

Copy link
Copy Markdown
Member Author

/copilot sync-branch

…ailures-behind-evidence-unavailable-without-actionable-diagnostics
@vypbot

vypbot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Branch synchronized

develop was merged into bugfix/619-approval-observer-hides-evidence-read-failures-behind-evidence-unavailable-without-actionable-diagnostics and pushed as 732f12d078041b5f83f78ecd6fe3df23010440c6.

6 verification checks passed.

@efraespada
efraespada merged commit 7c895ca into develop Oct 20, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

90% Progress: 90% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Approval observer hides evidence read failures behind evidence unavailable without actionable diagnostics

3 participants