Skip to content

fix: bugfix intermittent hosted Windows permission journal test exceeds Jest timeout (#577) - #638

Merged
efraespada merged 1 commit into
developfrom
bugfix/577-bugfix-intermittent-hosted-windows-permission-journal-test-exceeds-jest-timeout
Oct 21, 2026
Merged

efraespada merged 1 commit into
developfrom
bugfix/577-bugfix-intermittent-hosted-windows-permission-journal-test-exceeds-jest-timeout

Conversation

@efraespada

@efraespada efraespada commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

The operator Actions permission fixture performs real durable journal I/O despite mocking GitHub. A rejected dispatch persists six journal versions with fsync, so slow filesystem operations can exhaust Jest's generic five-second deadline before authority-isolation and cleanup assertions finish. The original Windows job timed out at 5,206 ms; its unchanged retry completed the case in 39 ms.

Give this disk-backed integration file a bounded 30-second test/hook budget, reusing its existing recovery-case budget. All eight cases retain real filesystem persistence and every credential-separation, cleanup, recovery and polling assertion. Document the scope and diagnostic evidence. Runtime behavior and other test suites' budgets are unchanged.

Investigation reproduced the same timeout by wrapping real journal flushes with 900 ms of added latency: the original case fails at five seconds, while the fix completes it in about 5.5 seconds. All eight cases also pass together under coverage with that delay and no CLI timeout override; recovery takes about 10.9 seconds. Historical logs lack per-operation traces, so this establishes the integration-budget mismatch without attributing the original host delay to a specific filesystem or runner component.

Validation:

  • 308 permission tests across 12 suites pass.
  • All eight affected tests pass under coverage with 900 ms added after each real flush.
  • Typecheck, lint and documentation contract validation pass.
  • Repository verification hook passes: build, 686 suites / 11,152 tests (35 existing skips), and lint.
  • Hosted Windows full-platform check passes on 4a3fe4bc: 11,130 tests passed, existing platform skips, coverage/acceptance budgets and all contract validators passed. The affected dispatch-denial case completed in 412 ms; readback denial in 121 ms.
  • Hosted Ubuntu and macOS full-platform checks pass on the same commit.

Closes #577.

@docs-page

docs-page Bot commented Oct 21, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~638

Documentation is deployed and generated using docs.page

@vypbot vypbot added size: XS Extra small task with minimal effort required. 65% Progress: 65% labels Oct 21, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.10%. Comparing base (274db40) to head (4a3fe4b).
⚠️ Report is 1555 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #638      +/-   ##
===========================================
+ Coverage    90.94%   94.10%   +3.16%     
===========================================
  Files          135      950     +815     
  Lines         6251    30548   +24297     
  Branches      1338     8965    +7627     
===========================================
+ Hits          5685    28748   +23063     
- Misses         172      704     +532     
- Partials       394     1096     +702     

see 1017 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vypbot vypbot changed the title Fix Windows permission journal fixture timeout fix: bugfix intermittent hosted Windows permission journal test exceeds Jest timeout (#577) Oct 21, 2026
@vypbot
vypbot self-requested a review October 21, 2026 08:20
@vypbot vypbot added this to vypdev Oct 21, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 21, 2026
@vypbot
vypbot changed the base branch from develop to master October 21, 2026 08:21
@vypbot
vypbot changed the base branch from master to develop October 21, 2026 08:21
@vypbot

vypbot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: Evidence passed; a human reviewer must decide.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 4a3fe4bc00e2; base: 58b5c544fac4; reason: recommend-mode.

@efraespada
efraespada marked this pull request as ready for review October 21, 2026 08:30
@vypbot

vypbot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 4a3fe4b.

Pull request · Verified commit · Workflow run

@efraespada
efraespada merged commit 6ecf1f4 into develop Oct 21, 2026
13 of 14 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

65% Progress: 65% size: XS Extra small task with minimal effort required. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - bugfix intermittent hosted Windows permission journal test exceeds Jest timeout

3 participants