Repository navigation
fix: bugfix intermittent hosted Windows permission journal test exceeds Jest timeout (#577) - #638
Merged
Conversation
|
To preview the documentation for this pull request, visit the following URL:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #638 +/- ##
===========================================
+ Coverage 90.94% 94.10% +3.16%
===========================================
Files 135 950 +815
Lines 6251 30548 +24297
Branches 1338 8965 +7627
===========================================
+ Hits 5685 28748 +23063
- Misses 172 704 +532
- Partials 394 1096 +702 🚀 New features to boost your workflow:
|
vypbot
self-requested a review
October 21, 2026 08:20
1 task done
Contributor
Copilot approval · Human review neededStatus: Evidence passed; a human reviewer must decide. Technical evidenceRevision: |
efraespada
marked this pull request as ready for review
October 21, 2026 08:30
Contributor
Bugbot: review complete
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The operator Actions permission fixture performs real durable journal I/O despite mocking GitHub. A rejected dispatch persists six journal versions with
fsync, so slow filesystem operations can exhaust Jest's generic five-second deadline before authority-isolation and cleanup assertions finish. The original Windows job timed out at 5,206 ms; its unchanged retry completed the case in 39 ms.Give this disk-backed integration file a bounded 30-second test/hook budget, reusing its existing recovery-case budget. All eight cases retain real filesystem persistence and every credential-separation, cleanup, recovery and polling assertion. Document the scope and diagnostic evidence. Runtime behavior and other test suites' budgets are unchanged.
Investigation reproduced the same timeout by wrapping real journal flushes with 900 ms of added latency: the original case fails at five seconds, while the fix completes it in about 5.5 seconds. All eight cases also pass together under coverage with that delay and no CLI timeout override; recovery takes about 10.9 seconds. Historical logs lack per-operation traces, so this establishes the integration-budget mismatch without attributing the original host delay to a specific filesystem or runner component.
Validation:
4a3fe4bc: 11,130 tests passed, existing platform skips, coverage/acceptance budgets and all contract validators passed. The affected dispatch-denial case completed in 412 ms; readback denial in 121 ms.Closes #577.