Repository navigation
fix: prevent workflow predecessor deadlocks on shared runners - #693
Merged
efraespada merged 3 commits intoOct 25, 2026
Conversation
…-shared-runners: fix runtime predecessor deadlocks with verified native coordination
|
To preview the documentation for this pull request, visit the following URL:
|
Contributor
Copilot approval · Human review neededStatus: Only open, non-draft, complete same-repository pull requests are eligible. Technical evidenceRevision: |
Contributor
Bugbot: review complete
|
…-shared-runners: rebuild runtime bundles with locked dependencies
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #693 +/- ##
===========================================
+ Coverage 90.94% 94.18% +3.23%
===========================================
Files 135 976 +841
Lines 6251 31709 +25458
Branches 1338 9315 +7977
===========================================
+ Hits 5685 29865 +24180
- Misses 172 702 +530
- Partials 394 1142 +748
🚀 New features to boost your workflow:
|
…-shared-runners: fully cover native coordination and queue boundaries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queued runs for unrelated PRs can no longer occupy shared runners while waiting for each other before setup. The runtime verifies the executing workflow's pinned native resource/lane contract and delegates coordination to GitHub; legacy and custom workflows retain the fail-closed predecessor fence.
What changed
GITHUB_WORKFLOW_SHA, select the direct executing job, and require the exact existing push, PR analysis or review-state group. Missing proof keeps the predecessor queue; provider, parsing and deadline failures stop before setup.Validation
972023c: 100% of modified coverable lines, with no missing or partial changed lines; all seven affected runtime files are 100% covered.972023c: 714 suites passed; 12,067 tests passed and 35 skipped. Global Jest coverage: 97.85% lines, 94.35% branches. All configured coverage budgets passed.972023c: Ubuntu, macOS and Windows passed.graphify update .completed.Review notes
CI follow-up: regenerated the runtime bundles after aligning the local installation with the committed lockfile (
undici 6.29.1). The lockfile and source implementation are unchanged by that follow-up; Linux and macOS now pass generated-bundle validation.Existing installations with the current native groups need the fixed runtime without workflow edits or a new input. A process already waiting in an older runtime must be inspected and rerun after upgrading, preserving necessary predecessor callbacks. Existing freshness, findings, permission and deployment guards remain in force.
Closes #692