Skip to content

fix: Automated Codecov User reports incorrectly make complete diff review context partial (#724) - #729

Merged
efraespada merged 2 commits into
developfrom
bugfix/724-automated-codecov-user-reports-incorrectly-make-complete-diff-review-context-partial
Oct 26, 2026
Merged

efraespada merged 2 commits into
developfrom
bugfix/724-automated-codecov-user-reports-incorrectly-make-complete-diff-review-context-partial

Conversation

@efraespada

@efraespada efraespada commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Preserves complete review discussion when it fits the existing 24,000-character section budget. A 4,000-character fragment boundary no longer clips a longer human comment or a User-account report and falsely makes the review partial.

The pure packing policy normalizes and sanitizes before splitting, preserves surrogate pairs and non-colliding untrusted framing, counts logical sources rather than fragments, and includes metadata, separators and omission notices in the final budget. Native automated-author filtering remains unchanged. Actual omissions, oversized sources, malformed Unicode and incomplete diff evidence cannot be presented as complete; approval rules remain in force.

Validation:

  • Full coverage run: 717 Jest suites / 12,143 passing tests, plus 56 extension tests. All existing coverage budgets pass. The new policy and existing context builder have 100% statements, branches, functions and lines covered. The final mandatory commit checks also pass: 717 suites / 12,144 tests, including the additional presentation regression.
  • The 13 required SDD case IDs cover reconstruction, Unicode, framing, exact budgets, native provider metadata, the real loader, independent partial sources and guarded approval. Architecture checks keep the policy free of infrastructure dependencies.
  • Real-source replay reconstructs both the 5,959-character Codecov report and the human issue comment identified as truncated by PR feat: Browser extension H2 browser runtime lifecycle protected sessions and actual browser harnesses (#703) #719. Existing partial-state UI was inspected at 390 × 844 pixels: completed diff, incomplete conversation, source identity, next action and navigation links remain readable without color.
  • Build, types, lint, specification/catalog and documentation validation pass. Tracked Action, CLI and API bundles are rebuilt. The owning SDD, companion, catalog and Bugbot documentation describe the same contract.

Remote verification at 50d084cdac077fa1a694a361d4527f1406003214: CI Check, Branch Sync, Commit, Pull Request and all hosted Linux/macOS/Windows platform jobs pass. Bugbot completes both diff partitions with complete input coverage and zero findings. Codecov reports 100.00% patch coverage and zero missed lines in both changed source files. The guarded Approval check is neutral by design (protected-path); it recommends a human decision and has not issued an automatic approval. Merged into develop as 70ce428342202b0eb320868134dc453f20ee575a after the maintainer explicitly confirmed this PR and its neutral protected-path recommendation. No administrative check bypass was used. Local replay is not a claim that PR #719 has already rerun successfully. This implements the published companion's generic lossless design; it does not add trusted-producer classification or public configuration.

Closes #724

vypbot and others added 2 commits October 26, 2026 16:17
…iff-review-context-partial: Preserve complete bounded review conversations for #724
@docs-page

docs-page Bot commented Oct 26, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~729

Documentation is deployed and generated using docs.page

@vypbot vypbot changed the title Preserve complete bounded Bugbot review conversations (#724) fix: Automated Codecov User reports incorrectly make complete diff review context partial (#724) Oct 26, 2026
@vypbot
vypbot self-requested a review October 26, 2026 15:55
@vypbot vypbot added this to vypdev Oct 26, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 26, 2026
@vypbot
vypbot changed the base branch from develop to master October 26, 2026 15:55
@vypbot
vypbot changed the base branch from master to develop October 26, 2026 15:55
@vypbot

vypbot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 50d084c.

Pull request · Verified commit · Workflow run

@vypbot vypbot added state:awaiting-maintainer state:ready size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. and removed state:ai-processing labels Oct 26, 2026
@vypbot

vypbot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 50d084cdac07; base: 5f8382a0a5c7; reason: protected-path.

@vypbot vypbot added the 70% Progress: 70% label Oct 26, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.25%. Comparing base (5f8382a) to head (50d084c).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #729      +/-   ##
===========================================
+ Coverage    94.24%   94.25%   +0.01%     
===========================================
  Files          989      990       +1     
  Lines        32020    32046      +26     
  Branches      9399     9404       +5     
===========================================
+ Hits         30176    30205      +29     
  Misses         702      702              
+ Partials      1142     1139       -3     
Files with missing lines Coverage Δ
...ion/policies/bugbot_conversation_packing_policy.ts 100.00% <100.00%> (ø)
...cases/steps/commit/bugbot/bugbot_review_context.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada
efraespada merged commit 70ce428 into develop Oct 26, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

70% Progress: 70% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Automated Codecov User reports incorrectly make complete diff review context partial

3 participants