Skip to content

fix(commands): explain rejected input with safe recovery - #733

Merged
efraespada merged 1 commit into
developfrom
bugfix/701-explain-rejected-comment-command-input-with-actionable-validation-errors
Oct 26, 2026
Merged

efraespada merged 1 commit into
developfrom
bugfix/701-explain-rejected-comment-command-input-with-actionable-validation-errors

Conversation

@efraespada

@efraespada efraespada commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

A rejected /copilot recheck could hide its actual syntax or size failure behind “Correct the input and retry.” Command failures now explain the safe cause and show a valid recovery example and help destination, without echoing rejected input.

What changed

  • Add 13 closed reason/command diagnostics using the existing semantic error and localized reply pipeline. Validate exact recovery variables and insert trusted command syntax after localization.
  • Preserve grammar, character/operand limits, member admission and mutation authorization. Remove raw option names/values from review and synchronization validation errors.
  • Audit all 21 command argument contracts and update help, user/operator documentation, owning SDDs and catalog evidence.

Validation

  • 100 new parser, privacy, locale and command-route cases, plus the shared recovery matrix. Reproduced four public failures before the fix.
  • Full coverage: 721 Jest suites / 12,289 passing tests (35 pre-existing skips); 267 extension tests with 100% of all measured coverage metrics. All 61 modified coverable production lines are covered locally against develop 1d9914f.
  • Specification/catalog, documentation, type, lint and dependency-cycle checks pass; Action/CLI/API bundles regenerated. Remote checks, complete review and exact-head/base Codecov remain required before merge.

Closes #701.

…idation-errors: explain rejected input with safe recovery (#701)
@docs-page

docs-page Bot commented Oct 26, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~733

Documentation is deployed and generated using docs.page

@vypbot vypbot added state:ai-processing size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. and removed state:ai-processing labels Oct 26, 2026
@vypbot
vypbot self-requested a review October 26, 2026 21:27
@vypbot vypbot added this to vypdev Oct 26, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 26, 2026
@vypbot vypbot added the 85% Progress: 85% label Oct 26, 2026
@vypbot
vypbot changed the base branch from develop to master October 26, 2026 21:27
@vypbot
vypbot changed the base branch from master to develop October 26, 2026 21:28
@vypbot

vypbot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 60ad8d9.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 60ad8d9a7584; base: 1d9914f06595; reason: protected-path.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.44%. Comparing base (1d9914f) to head (60ad8d9).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #733      +/-   ##
===========================================
+ Coverage    94.43%   94.44%   +0.01%     
===========================================
  Files         1025     1030       +5     
  Lines        33018    33055      +37     
  Branches      9737     9746       +9     
===========================================
+ Hits         31180    31219      +39     
+ Misses         702      701       -1     
+ Partials      1136     1135       -1     
Files with missing lines Coverage Δ
...ication/errors/comment_command_validation_error.ts 100.00% <100.00%> (ø)
...tion/policies/application_error_message_catalog.ts 100.00% <100.00%> (ø)
.../policies/application_error_presentation_policy.ts 100.00% <100.00%> (ø)
...cies/comment_command_validation_message_catalog.ts 100.00% <100.00%> (ø)
.../comment_command_validation_presentation_policy.ts 100.00% <100.00%> (ø)
...application/policies/copilot_interaction_policy.ts 100.00% <ø> (ø)
...pplication/policies/publication_message_catalog.ts 100.00% <ø> (ø)
...secases/branch_sync/branch_sync_comment_command.ts 100.00% <100.00%> (ø)
...on/usecases/comment_automation_command_workflow.ts 92.13% <100.00%> (+1.22%) ⬆️
...pplication/usecases/comment_automation_use_case.ts 95.83% <100.00%> (+4.16%) ⬆️
... and 6 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada
efraespada merged commit 7023df9 into develop Oct 26, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

85% Progress: 85% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Explain rejected comment command input with actionable validation errors

3 participants