Skip to content

fix(sdd): expose blocked preparation and safe validation evidence - #734

Merged
efraespada merged 4 commits into
developfrom
bugfix/714-expose-blocked-pre-branch-sdd-outcomes-and-safe-recoverable-draft-diagnostics
Oct 27, 2026
Merged

efraespada merged 4 commits into
developfrom
bugfix/714-expose-blocked-pre-branch-sdd-outcomes-and-safe-recoverable-draft-diagnostics

Conversation

@efraespada

@efraespada efraespada commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

A rejected pre-branch specification could leave only a welcome comment and tell maintainers to inspect a draft that was never published. The gate now maintains an actionable blocked status card with safe validation evidence and recovery instructions on that same issue.

What changed

  • Publish closed check IDs and bounded section/row/count facts through the existing bot-owned analysis-status card. Candidate content, identifiers, paths, raw messages and credentials stay outside this diagnostic publication.
  • Preserve strict validation, the single shared repair, answers and immutable owners. Withhold stale evidence, suppress the optional welcome while blocked, recover on the exact existing branch, and retain verified publication if refreshing its diagnostic card fails.
  • Recheck stale issue/title/source before retaining publication-recovery records and again after diagnostic localization. A revision recognizes only its exact returned commit as an expected source advance.
  • Restore waiting status on existing incomplete-question retries, preserving questions/answers and guarding recovery against stale sources and deletion races.
  • Reuse the existing upsert seam and keep the reviewed mutation inventory counts unchanged. Resolve complete localized copy, validate runtime-only run links, and cap the card with explicit English fallback.
  • Update owning SDDs, catalog evidence, user recovery/retention guidance and contributor/error documentation.

Validation

  • Reproduced three functional failures before the fix. Deterministic tests cover actual validator evidence, privacy, forged data/markers, bounds, localization, replay, partial publication and same-issue recovery.
  • Full coverage: 723 Jest suites / 12,416 passing tests (35 pre-existing skips); 267 extension tests with 100% of all measured coverage metrics. All 209 modified coverable production lines are covered locally against develop 7023df9a, with zero partially covered branches on modified lines.
  • 127 new regression cases; new diagnostic schema, error and catalog modules reach 100% of every coverage metric, and the renderer reaches 100% of every coverage metric.
  • Type/lint, specification/catalog/documentation, dependency-cycle/publication-inventory and npm package/smoke checks pass; bundles and Graphify refreshed.
  • Remote complete review, all applicable checks and Codecov covering every modified coverable line are required before merge; protected human approval remains independent.

Closes #714.

…e-draft-diagnostics: publish safe blocked preparation diagnostics (#714)
…e-draft-diagnostics: report precise failing validation facts
@docs-page

docs-page Bot commented Oct 26, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~734

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review October 26, 2026 23:36
@vypbot vypbot added the size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. label Oct 26, 2026
@vypbot vypbot added this to vypdev Oct 26, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 26, 2026
@vypbot
vypbot changed the base branch from develop to master October 26, 2026 23:37
@vypbot vypbot added the 90% Progress: 90% label Oct 26, 2026
@vypbot
vypbot changed the base branch from master to develop October 26, 2026 23:37

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on 14fbe5d. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit 189f231 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • medium: Stale publication attempts can overwrite the current status card — src/application/usecases/sdd/pre_branch_sdd_gate_use_case.ts:281

@vypbot

vypbot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 14fbe5d.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 14fbe5de04f2; base: 7023df9a0597; reason: protected-path.

@codecov-commenter

codecov-commenter commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.48%. Comparing base (7023df9) to head (14fbe5d).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #734      +/-   ##
===========================================
+ Coverage    94.44%   94.48%   +0.04%     
===========================================
  Files         1030     1034       +4     
  Lines        33055    33223     +168     
  Branches      9746     9799      +53     
===========================================
+ Hits         31219    31392     +173     
+ Misses         701      699       -2     
+ Partials      1135     1132       -3     
Files with missing lines Coverage Δ
...pplication/errors/sdd_draft_preparation_failure.ts 100.00% <100.00%> (ø)
...tion/policies/application_error_message_catalog.ts 100.00% <ø> (ø)
...cation/policies/sdd_preparation_message_catalog.ts 100.00% <100.00%> (ø)
...lication/policies/sdd_preparation_status_policy.ts 100.00% <100.00%> (ø)
src/application/usecases/issue_workflow.ts 96.80% <100.00%> (ø)
...tion/usecases/sdd/pre_branch_sdd_draft_workflow.ts 100.00% <100.00%> (ø)
...ation/usecases/sdd/pre_branch_sdd_gate_use_case.ts 93.44% <100.00%> (+3.64%) ⬆️
src/domain/pre_branch_sdd.ts 87.56% <100.00%> (+0.79%) ⬆️
src/domain/sdd_draft_consistency.ts 100.00% <100.00%> (ø)
src/domain/sdd_validation_diagnostic.ts 100.00% <100.00%> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…e-draft-diagnostics: guard publication recovery against stale sources

@vypbot vypbot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current status: All findings originating in this review are resolved.
Last reconciled on 14fbe5d. See aggregate Bugbot status.

🤖 Bugbot review snapshot

Bugbot reported 1 potential problem when commit d6bf65d was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.

Findings

  • low: Clear failure status when existing questions remain unanswered — src/application/usecases/sdd/pre_branch_sdd_gate_use_case.ts:217

…e-draft-diagnostics: restore waiting status and cover diagnostic boundaries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

75% Progress: 75% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Expose blocked pre branch SDD outcomes and safe recoverable draft diagnostics

3 participants