Skip to content

fix(bugbot): validate Compose width semantics and suggested constraints - #744

Merged
efraespada merged 2 commits into
developfrom
bugfix/720-pr-review-confuses-compose-width-with-requiredwidth-suggested-modifier-order-removes-width-cap
Oct 27, 2026
Merged

efraespada merged 2 commits into
developfrom
bugfix/720-pr-review-confuses-compose-width-with-requiredwidth-suggested-modifier-order-removes-width-cap

Conversation

@efraespada

@efraespada efraespada commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Bugbot now grounds Compose width findings and suggested fixes in actual constraints, modifier order, padding, and interactive bounds. The change addresses issue #720’s false overflow claim while preserving detection of real overflow and lost width caps.

What changed

  • Updated production and benchmark guidance to distinguish constraint-respecting preferred widths from required widths and to verify replacement behavior at narrow and wide boundaries.
  • Added five Compose benchmark cases and seven automated regressions spanning width behavior, modifier ordering, padding, and both prompt consumers.
  • Documented the benchmark scope and recorded real-model observations separately from reference predictions.

Validation

  • Focused prompt and evaluator tests: 27 passed; final padding-contract selection: 19 passed.
  • Typecheck, lint, specification/catalog, documentation, agent docs, docs-page assets, and package validation passed; Graphify updated.
  • Coverage campaign had three 5-second infrastructure timeouts; both affected suites passed in isolation (34 tests) with unchanged limits.
  • Full pre-commit verification passed: build, all 725 suites / 12,504 tests with 35 configured skips, and lint.

Review notes

  • The final five-case gpt-6-luna sample had zero false positives and zero missed defects, but the full quality gate still fails exact location (line 9 instead of Card line 10) and severity (medium instead of reference low). No statistical model improvement or complete model-quality pass is claimed.

Closes #720

…ted-modifier-order-removes-width-cap: ground Compose width findings and replacement constraints
@docs-page

docs-page Bot commented Oct 27, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~744

Documentation is deployed and generated using docs.page

@vypbot vypbot added size: XL Indicates that the issue or task is extra large in scope and complexity. 90% Progress: 90% state:ai-processing labels Oct 27, 2026
@vypbot
vypbot self-requested a review October 27, 2026 09:16
@vypbot vypbot added this to vypdev Oct 27, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 27, 2026
@vypbot
vypbot changed the base branch from develop to master October 27, 2026 09:17
@vypbot
vypbot changed the base branch from master to develop October 27, 2026 09:17
@vypbot

vypbot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on daa6842.

Pull request · Verified commit · Workflow run

@codecov-commenter

codecov-commenter commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.50%. Comparing base (8de9b63) to head (daa6842).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #744   +/-   ##
========================================
  Coverage    94.50%   94.50%           
========================================
  Files         1035     1035           
  Lines        33298    33298           
  Branches      9824     9824           
========================================
  Hits         31467    31467           
  Misses         699      699           
  Partials      1132     1132           
Files with missing lines Coverage Δ
src/prompts/bugbot.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vypbot

vypbot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: daa68427c586; base: 8de9b63ab4ba; reason: protected-path.

@efraespada

Copy link
Copy Markdown
Member Author

/copilot sync-branch --from develop

@vypbot

vypbot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Request could not be completed

Impact: The workflow could not complete the requested operation.

Action: Inspect the current state and retry the failed step.

Retained state: Existing persisted state and completed external effects were preserved.

Error code: workflow.failed

Retryable: Yes

Reference: da13f463-45b7-4587-a960-0a273cb4dc84

…ted-modifier-order-removes-width-cap: Merge develop into #720 preserving both Compose review contracts

Resolve the eleven conflicts between #720 width/padding review grounding and
#722 framework-owned startup cleanup, retaining both sets of fixtures and
reference predictions (48 cases), both specification sections, their evidence
and non-conflicting parent changes. Regenerate the catalog and all bundles
from the combined source.

Recovery follows the maintainer request to resolve the conflicts after Action
run 40482345521 failed verification because the extension dependencies were
unavailable in that runner environment. The Action did not push a merge.

Child: c9df3cf
Parent develop: 8de9b63
Plan: preserve both histories, run the existing verification gates and hooks,
and publish a normal push to the existing managed ref without bypass or force.

Validation: 725 suites and 12,511 tests passed (35 configured skips), all
coverage budgets and the unchanged setup ledger passed; the modified prompt
module has 100% coverage. Extension: 30 files / 267 tests passed with 100%
coverage in every metric. Focused combined review regression selection: 34
passed. Build, typecheck, lint, specifications/catalog and documentation passed.
@vypbot vypbot added the 85% Progress: 85% label Oct 27, 2026
@efraespada
efraespada merged commit 74a2b60 into develop Oct 27, 2026
12 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

85% Progress: 85% size: XL Indicates that the issue or task is extra large in scope and complexity. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - PR review confuses Compose width with requiredWidth suggested modifier order removes width cap

3 participants