Skip to content

fix(progress): use native PR comparison for inherited binary baselines - #752

Merged
efraespada merged 1 commit into
developfrom
bugfix/727-progress-assessment-fails-permanently-on-inherited-binary-files-without-github-textual-patches
Oct 27, 2026
Merged

efraespada merged 1 commit into
developfrom
bugfix/727-progress-assessment-fails-permanently-on-inherited-binary-files-without-github-textual-patches

Conversation

@efraespada

@efraespada efraespada commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Progress assessments compared every managed branch with configured development, even when its native PR targeted production. That treated unchanged inherited binaries as issue changes and blocked otherwise reviewable maintenance work. This change selects and pins the actual native PR target, while retaining the development fallback only after verified PR absence.

What changed

  • Resolve exact same-repository PR ownership through a bounded read-only capability; reject ambiguity, unavailable authority and changed ownership/refs before publishing progress.
  • Preserve complete evidence and fail closed for actually changed unsupported binaries. Report exact bounded paths, the complete inventory in run details, and recovery guidance that distinguishes unavailable assessment from project verification.
  • Frame native branch metadata as untrusted prompt data; update the owning SDD, budgets, catalog, user documentation and generated bundles.

Validation

  • Full coverage: 753 suites, 13,329 passing tests and 35 existing skips; all global/module budgets and setup acceptance passed. Extension: 267 tests and 100% in all four metrics.
  • Changed-line audit: 102 covered executable lines, zero uncovered lines/branches. New source selection, diagnostic helpers, adapter and composition have 100% in all four metrics. Remote Codecov and review remain independent gates.
  • Root/extension types, lint, specifications/catalog, docs, workflows, architecture-cycle checks, generated bundles, npm package and CLI/API/local-web smoke passed. Graphify updated.
  • Normal commit hooks passed build, all 753 Jest suites and lint. The first attempt hit one existing Windows CLI-upgrade fixture timeout; its isolated 29 tests and the complete normal retry passed without code/timeout changes.

Review notes

The public consumer evidence was reproduced through read-only native APIs: development-to-head had 55 paths including five patchless binaries; the historical PR's production-to-head comparison had 15 text paths. Deterministic integration fixtures preserve that distinction. This does not claim live consumer adoption, binary-content review or successful execution of a consumer build. Unsupported binary add/modify/delete/rename remain blocked before model calls and retain prior progress. The independent optional Check Run warning remains tracked in #728.

Closes #727

…files-without-github-textual-patches: pin native review target and retain honest binary diagnostics
@docs-page

docs-page Bot commented Oct 27, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~752

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review October 27, 2026 22:43
@vypbot vypbot added the size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. label Oct 27, 2026
@vypbot vypbot added this to vypdev Oct 27, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 27, 2026
@vypbot
vypbot changed the base branch from develop to master October 27, 2026 22:43
@vypbot
vypbot changed the base branch from master to develop October 27, 2026 22:44
@vypbot

vypbot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on b46ed4e.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: b46ed4ee62ae; base: 7fc413c63413; reason: protected-path.

@vypbot vypbot added the 65% Progress: 65% label Oct 27, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.68%. Comparing base (5b3664f) to head (b46ed4e).
⚠️ Report is 23 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #752      +/-   ##
===========================================
+ Coverage    94.50%   94.68%   +0.18%     
===========================================
  Files         1035     1060      +25     
  Lines        33299    34187     +888     
  Branches      9824    10110     +286     
===========================================
+ Hits         31468    32371     +903     
+ Misses         699      684      -15     
  Partials      1132     1132              
Files with missing lines Coverage Δ
...tion/policies/application_error_message_catalog.ts 100.00% <ø> (ø)
.../policies/application_error_presentation_policy.ts 100.00% <100.00%> (ø)
...tion/policies/progress_comparison_source_policy.ts 100.00% <100.00%> (ø)
...ation/policies/progress_content_evidence_policy.ts 100.00% <100.00%> (ø)
...cation/usecases/actions/check_progress_use_case.ts 100.00% <100.00%> (ø)
...cation/usecases/actions/check_progress_workflow.ts 90.74% <100.00%> (-5.18%) ⬇️
...ion/usecases/actions/progress_analysis_workflow.ts 97.18% <100.00%> (-1.04%) ⬇️
src/data/model/application_error.ts 100.00% <100.00%> (ø)
...epository/immutable_progress_content_repository.ts 100.00% <100.00%> (ø)
...epository/progress_comparison_source_repository.ts 100.00% <100.00%> (ø)
... and 7 more

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada
efraespada merged commit a953df8 into develop Oct 27, 2026
12 of 13 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

65% Progress: 65% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Progress assessment fails permanently on inherited binary files without GitHub textual patches

3 participants