Repository navigation
fix(checks): make optional evidence failures actionable - #753
Merged
Conversation
…agnostics-in-the-commit-workflow: retain safe optional-publication diagnostics
|
To preview the documentation for this pull request, visit the following URL:
|
vypbot
self-requested a review
October 28, 2026 00:10
1 task done
Contributor
Bugbot: review complete
|
Contributor
Copilot approval · Human review neededStatus: A protected workflow, policy, or trust-boundary file changed. Technical evidenceRevision: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #753 +/- ##
===========================================
+ Coverage 94.50% 94.69% +0.19%
===========================================
Files 1035 1063 +28
Lines 33299 34239 +940
Branches 9824 10135 +311
===========================================
+ Hits 31468 32423 +955
+ Misses 699 684 -15
Partials 1132 1132
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional Check Run publication previously lost the failed operation and provider facts, and a custom semantic error could leak its private message. This change reports a bounded, localized diagnostic in the run log and a Job Summary appendix while preserving required-stage success/failure and completed effects.
What changed
checks.createoperation, complete valid head, check name and credential-selection route. Unknown failures stay unknown; credentials, raw bodies/headers, URLs and exception messages are excluded.Validation
Review notes
The original consumer warnings establish no provider HTTP status, credential type or outage. A transported write can be completed before its response is lost, so recovery instructs inspection of the same native head before replay. Native Check identity and source eligibility are preserved; this does not add a provider-idempotent upsert registry or fabricate a head for an ineligible event. Optional publication and its Summary appendix never replace an earlier required error or turn successful required work into failure.
Closes #728