Repository navigation
fix: Bugbot predicts failing test despite indirect participant binding and passing typed fault assertion (#738) - #757
Conversation
…binding-and-passing-typed-fault-assertion: ground test failure claims in delegated call and error paths
|
To preview the documentation for this pull request, visit the following URL:
|
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled onc4f4642. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit d7d541c was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- high: Corpus snippets execute as code in the test process —
src/tooling/__tests__/bugbot_benchmark.test.ts:150
Bugbot: review complete
|
Copilot approval · Human review neededStatus: A protected workflow, policy, or trust-boundary file changed. Technical evidenceRevision: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #757 +/- ##
===========================================
+ Coverage 94.50% 94.79% +0.28%
===========================================
Files 1035 1078 +43
Lines 33299 34858 +1559
Branches 9824 10354 +530
===========================================
+ Hits 31468 33042 +1574
+ Misses 699 684 -15
Partials 1132 1132
🚀 New features to boost your workflow:
|
…binding-and-passing-typed-fault-assertion: keep benchmark corpus inert with compiled call-path oracles
Bugbot can incorrectly claim that a test necessarily fails when it inspects only the public method and misses an indirect binding call. Review now selects the concrete parameterized case, traces delegates and bound callbacks through the fixture guards, and follows the typed failure to the exact assertion before retaining that claim.
What changed
Validation
Review notes
The actual six-case product-runtime comparison is retained separately from reference predictions in issue-738.json. Both observed runs fail the full default model score. The corrected sample has zero matched false positives/negatives, but exact location accuracy is 1/3: two anchors are off by one. Inputs, expected findings and thresholds were unchanged. This is not reproduction of the historical false positive, an all-thresholds-passed model result or a statistical improvement claim.
This is model guidance using the existing bounded read-only capabilities and publication/resolution protections. The native oracles run compiled authored test factories, with corpus text compared only as data; they do not execute the consumer's Kotlin/JDK/database tests. No resolver service, permission, schema, configuration or lifecycle surface is added.
Closes #738.