Skip to content

fix: restore explicit launcher issue on tag-push publication - #761

Merged
efraespada merged 1 commit into
developfrom
bugfix/740-tag-push-createrelease-loses-the-explicit-action-issue-and-blocks-finalization-after-all-packages-publish
Oct 28, 2026
Merged

efraespada merged 1 commit into
developfrom
bugfix/740-tag-push-createrelease-loses-the-explicit-action-issue-and-blocks-finalization-after-all-packages-publish

Conversation

@efraespada

@efraespada efraespada commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Tag-push create_release could discard the validated single-action-issue, lose its stored operation, and report missing context as supersession after packages had published. Setup now verifies the explicit positive target before event/ref hints and restores only that issue's configuration.

Closes #740.

What changed

  • Preserve native issue/PR classification, PR-to-issue translation, repository-only initial setup and optional Think context. A missing explicit target or failed lookup cannot redirect execution to incidental event work.
  • Report unavailable publication context as nonretryable configuration.invalid with closed EN/ES/English-fallback recovery guidance that preserves completed effects. Existing operation ID, version, phase and accepted production SHA fences remain mandatory before release creation.
  • Update SDDs, catalog, public configuration/error docs and generated bundles. No consumer publication or recovery was performed.

Validation

  • 32 new distinct regressions plus the shared exhaustive recovery fixture; 100 setup/publication directed tests and 112 exhaustive diagnostic/integration checks pass. The before-fix run reproduced 25 semantic failures.
  • Complete coverage run: 773 suites, 14,165 tests passed, 35 existing omissions; all global/module budgets and setup acceptance passed. Extension: 267 tests, 100% statements/branches/functions/lines.
  • Local diff audit: all 6 changed executable lines covered, zero misses or uncovered modified branches. Remote Codecov/review/CI must still confirm the final commit before merge.
  • Types/lint, specs/catalog, documentation/workflows/agent docs, Graphify, build/package (87 files), and CLI + typed API + isolated local web smoke passed.

Final local commit: a1d0724d08a1d4c7be970ddb12271ca93fdddff9 (parent a3f3e3e5e9aaeb8b4496236a3885cd1ebbb8048f). Normal build/full-Jest/lint hooks passed; the post-hook source/bundle hashes match the fully covered candidate.

…-blocks-finalization-after-all-packages-publish: preserve explicit Action targets during publication setup
@docs-page

docs-page Bot commented Oct 28, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~761

Documentation is deployed and generated using docs.page

@vypbot
vypbot self-requested a review October 28, 2026 11:52
@vypbot vypbot added the size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. label Oct 28, 2026
@vypbot vypbot added this to vypdev Oct 28, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 28, 2026
@vypbot
vypbot changed the base branch from develop to master October 28, 2026 11:52
@vypbot
vypbot changed the base branch from master to develop October 28, 2026 11:52
@vypbot vypbot added the 75% Progress: 75% label Oct 28, 2026
@vypbot

vypbot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on a1d0724.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: a1d0724d08a1; base: a3f3e3e5e9aa; reason: protected-path.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.80%. Comparing base (5b3664f) to head (a1d0724).
⚠️ Report is 41 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #761      +/-   ##
===========================================
+ Coverage    94.50%   94.80%   +0.30%     
===========================================
  Files         1035     1078      +43     
  Lines        33299    34864    +1565     
  Branches      9824    10357     +533     
===========================================
+ Hits         31468    33053    +1585     
+ Misses         699      682      -17     
+ Partials      1132     1129       -3     
Files with missing lines Coverage Δ
...tion/policies/application_error_message_catalog.ts 100.00% <ø> (ø)
...cation/usecases/actions/create_release_workflow.ts 100.00% <100.00%> (+3.84%) ⬆️
...secases/execution/execution_issue_number_policy.ts 97.95% <100.00%> (+0.04%) ⬆️
src/data/model/application_error.ts 100.00% <100.00%> (ø)

... and 47 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada
efraespada merged commit e3917cd into develop Oct 28, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

75% Progress: 75% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Tag push createrelease loses the explicit Action issue and blocks finalization after all packages publish

3 participants