Skip to content

fix: preserve nested SDD catalog links - #780

Merged
efraespada merged 1 commit into
developfrom
bugfix/768-bug-sdd-catalog-links-discard-nested-specification-directories
Oct 29, 2026
Merged

efraespada merged 1 commit into
developfrom
bugfix/768-bug-sdd-catalog-links-discard-nested-specification-directories

Conversation

@efraespada

@efraespada efraespada commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Catalog generation now preserves nested specification paths in primary and companion links, so links resolve to the intended SDD even when files in different directories share a basename. Root-level specification links and repository-relative evidence links retain their existing formats.

What changed

  • Preserve each specification’s full path after specs/ in the primary-SDD table and evidence map across the validator and generated bundles.
  • Add portable filesystem regressions for root, nested, deep, companion, duplicate-basename, and non-specification evidence layouts.
  • Document nested-link behavior and catalog regeneration guidance; update the catalog and SDD records.

Validation

  • Five nested-layout regressions failed before the fix and passed afterward; 51 validator tests and 24 branch-sync tests passed.
  • Targeted Node V8 coverage passed for renderCatalog (5/5) and renderPathLinks (6/6), including callbacks.
  • Commit hooks passed build, 773 suites / 14,202 tests (35 platform skips), and lint. Typecheck, specification generation and validation, documentation/workflow contracts, extension/package validation, and CLI/API/local-web package smoke checks also passed.

Review notes

  • Remote full coverage and an exact-head review without unresolved findings remain required before merge.

Closes #768

@docs-page

docs-page Bot commented Oct 29, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~780

Documentation is deployed and generated using docs.page

@vypbot vypbot added size: L Indicates a large-sized task or issue that requires significant effort and time. 75% Progress: 75% state:ai-processing labels Oct 29, 2026
@vypbot
vypbot self-requested a review October 29, 2026 02:01
@vypbot vypbot added this to vypdev Oct 29, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 29, 2026
@vypbot
vypbot changed the base branch from develop to master October 29, 2026 02:01
@efraespada efraespada linked an issue Oct 29, 2026 that may be closed by this pull request
1 task done
@vypbot
vypbot changed the base branch from master to develop October 29, 2026 02:02
@vypbot

vypbot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on a3c8ab4.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: a3c8ab4837f6; base: a3ce74c7c5e9; reason: protected-path.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.80%. Comparing base (5b3664f) to head (a3c8ab4).
⚠️ Report is 55 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #780      +/-   ##
===========================================
+ Coverage    94.50%   94.80%   +0.30%     
===========================================
  Files         1035     1078      +43     
  Lines        33299    34865    +1566     
  Branches      9824    10357     +533     
===========================================
+ Hits         31468    33054    +1586     
+ Misses         699      682      -17     
+ Partials      1132     1129       -3     

see 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada
efraespada merged commit 42c66f1 into develop Oct 29, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

75% Progress: 75% size: L Indicates a large-sized task or issue that requires significant effort and time. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - bug SDD catalog links discard nested specification directories

3 participants