Skip to content

fix: defer deployment issue completion until publication and reconciliation - #802

Merged
efraespada merged 1 commit into
developfrom
bugfix/792-release-issue-closes-and-reaches-100-at-production-promotion-before-publication-and-reconciliation
Oct 30, 2026
Merged

efraespada merged 1 commit into
developfrom
bugfix/792-release-issue-closes-and-reaches-100-at-production-promotion-before-publication-and-reconciliation

Conversation

@efraespada

@efraespada efraespada commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Promotion PRs created from a release or hotfix launcher’s linked branch can close that issue as soon as GitHub merges into the default branch, before publication or reconciliation. Verify the managed PR’s native identity, remove only its launcher closing reference, and require the reference to be absent before the configured merge handoff. Ordinary issue completion remains unchanged.

Pending deployment state now defers generic closure, completion labels and project retirement. Finalization persists verified functional completion before closing the issue, then verifies native metadata reconciliation. A failed issue projection remains actionable and can be retried through trusted publication completion without republishing or repeating successful cleanup.

Closes #792.

Validation:

  • 53 new regression cases; 700 focused tests pass across 20 suites, with all changed-module coverage floors passing and pure completion policies at 100% for all metrics.
  • Stateful provider fixtures reproduce native closure before the PR-closed handler, demonstrate the corrected release/hotfix sequence, retain the closing-keyword failure case, and preserve ordinary issue closure. These are deterministic fixtures, not a live release or private-consumer deployment.
  • Node and extension type checks, lint, specification/catalog, documentation, workflow and generated-build validation pass; npm package validation and isolated CLI/API/web smoke pass; AST knowledge graph updated.
  • Full normal commit hook passes: 806 suites, 15,116 tests passed and 35 existing skips, plus build and lint. Exact-head CI/native Linux, macOS, Windows, patch coverage and complete review remain merge gates.

Native API calls are bounded observations, not atomic compare-and-swap. Unsupported or retained closing relationships block merge handoff. Existing prematurely closed issues are not automatically reopened.

…on-before-publication-and-reconciliation: defer deployment issue completion until verified publication (#792)
@docs-page

docs-page Bot commented Oct 30, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~802

Documentation is deployed and generated using docs.page

@vypbot vypbot added size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. 65% Progress: 65% state:ai-processing labels Oct 30, 2026
@vypbot
vypbot self-requested a review October 30, 2026 10:21
@vypbot vypbot added this to vypdev Oct 30, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 30, 2026
@vypbot
vypbot changed the base branch from develop to master October 30, 2026 10:21
@vypbot
vypbot changed the base branch from master to develop October 30, 2026 10:22
@vypbot

vypbot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on d2224b0.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: d2224b020db1; base: 65ef79e230db; reason: protected-path.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.22481% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.10%. Comparing base (5b3664f) to head (d2224b0).
⚠️ Report is 95 commits behind head on develop.

Files with missing lines Patch % Lines
src/testing/deployment_operation_fixture.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #802      +/-   ##
===========================================
+ Coverage    94.50%   95.10%   +0.60%     
===========================================
  Files         1035     1100      +65     
  Lines        33299    36016    +2717     
  Branches      9824    10753     +929     
===========================================
+ Hits         31468    34252    +2784     
+ Misses         699      674      -25     
+ Partials      1132     1090      -42     
Files with missing lines Coverage Δ
src/actions/github_action_completion.ts 93.52% <100.00%> (+0.61%) ⬆️
...cies/closed_issue_reconciliation_outcome_policy.ts 100.00% <100.00%> (ø)
...ication/policies/deployment_presentation_policy.ts 99.35% <100.00%> (+0.04%) ⬆️
...c/application/services/deployment_merge_effects.ts 100.00% <100.00%> (ø)
...usecases/actions/deferred_deployment_completion.ts 100.00% <100.00%> (ø)
...deployment_handlers/confirm_publication_handler.ts 94.33% <100.00%> (-0.11%) ⬇️
...ions/deployment_handlers/reconciliation_handler.ts 96.42% <100.00%> (+0.63%) ⬆️
...ctions/reconcile_closed_issue_metadata_use_case.ts 100.00% <100.00%> (ø)
...on/usecases/actions/retire_branch_sync_use_case.ts 97.10% <100.00%> (+0.08%) ⬆️
...ation/usecases/actions/retire_progress_use_case.ts 94.02% <100.00%> (+0.18%) ⬆️
... and 10 more

... and 132 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada
efraespada merged commit ab5f7d7 into develop Oct 30, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

65% Progress: 65% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Release issue closes and reaches 100 at production promotion before publication and reconciliation

3 participants