Repository navigation
fix: defer deployment issue completion until publication and reconciliation - #802
Merged
Conversation
…on-before-publication-and-reconciliation: defer deployment issue completion until verified publication (#792)
|
To preview the documentation for this pull request, visit the following URL:
|
vypbot
self-requested a review
October 30, 2026 10:21
1 task done
Contributor
Bugbot: review complete
|
Contributor
Copilot approval · Human review neededStatus: A protected workflow, policy, or trust-boundary file changed. Technical evidenceRevision: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #802 +/- ##
===========================================
+ Coverage 94.50% 95.10% +0.60%
===========================================
Files 1035 1100 +65
Lines 33299 36016 +2717
Branches 9824 10753 +929
===========================================
+ Hits 31468 34252 +2784
+ Misses 699 674 -25
+ Partials 1132 1090 -42
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotion PRs created from a release or hotfix launcher’s linked branch can close that issue as soon as GitHub merges into the default branch, before publication or reconciliation. Verify the managed PR’s native identity, remove only its launcher closing reference, and require the reference to be absent before the configured merge handoff. Ordinary issue completion remains unchanged.
Pending deployment state now defers generic closure, completion labels and project retirement. Finalization persists verified functional completion before closing the issue, then verifies native metadata reconciliation. A failed issue projection remains actionable and can be retried through trusted publication completion without republishing or repeating successful cleanup.
Closes #792.
Validation:
Native API calls are bounded observations, not atomic compare-and-swap. Unsupported or retained closing relationships block merge handoff. Existing prematurely closed issues are not automatically reopened.