Repository navigation
fix: Bugbot confuses generated Kotlin source lines and flags correct JaCoCo missed line assertions (#796) - #805
Conversation
…rrect-jacoco-missed-line-assertions: verify generated literal counter findings
|
To preview the documentation for this pull request, visit the following URL:
|
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled onf7b4f19. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit fddfeef was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- low: Mixed tab and space indentation produces incorrect dedent witnesses —
src/application/policies/bugbot_python_literal_witness_policy.ts:176
Bugbot: review complete
|
Copilot approval · Human review neededStatus: A protected workflow, policy, or trust-boundary file changed. Technical evidenceRevision: |
|
/copilot recheck effort=high Please independently re-evaluate finding |
Request could not be completed
Action: Correct the input and retry. Retained state: No new state or external effect was created. Error code: Retryable: No Reference: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #805 +/- ##
===========================================
+ Coverage 94.50% 95.16% +0.66%
===========================================
Files 1035 1103 +68
Lines 33299 36292 +2993
Branches 9824 10834 +1010
===========================================
+ Hits 31468 34536 +3068
+ Misses 699 673 -26
+ Partials 1132 1083 -49
🚀 New features to boost your workflow:
|
…rrect-jacoco-missed-line-assertions: cover retained literal and dedent contracts
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled onf7b4f19. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit 059d679 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- medium: More than 20 findings make literal verification fail the review —
src/application/usecases/steps/commit/bugbot/verify_generated_literal_findings.ts:63
…rrect-jacoco-missed-line-assertions: verify all schema-valid candidates in bounded batches
…rrect-jacoco-missed-line-assertions: separate response and prompt byte limits
Bugbot could mistake Python host lines for generated Kotlin lines and flag a correct missed-coverage assertion as failing. Review now receives bounded, inert numbered literal evidence and independently verifies candidate hypotheses against the same source before publication.
What changed
Validation
Review notes
The six-case model sample still fails the unchanged exact-location gate (0/2); complete scores and failed intermediate campaigns remain in
quality/bugbot/evidence/issue-796.json. This is not an all-model-gates pass. The sample does not test publication remapping or establish statistical accuracy or consumer adoption. Consumer evidence was read-only; committed fixtures are synthetic.Read-only verification runs only for retained Python literal witnesses with nonempty candidates, using the same provider/model/effort. Support all 1–200 schema-valid candidates in at most ten sequential batches of 20, preflighting global identity and the 32,000-byte candidate limit per batch. Keep the 128,000-byte complete-prompt bound per query and existing three partition attempts (at most 33 total queries). Serialized initial/secondary JSON replies have a separate 4,000,000-byte UTF-8 wire bound, preserving object/string equivalence for valid batched responses above the prompt ceiling. A later failure cannot publish partial results or resolve historical findings. Count every initial/retried and secondary query in telemetry. No new public configuration or historical finding mutation authority.
Closes #796.