Repository navigation
fix(pull-request): preserve verified closing intent during description rewrites - #813
Conversation
…pproval-requires-its-text: preserve verified closing intent across description rewrites
|
To preview the documentation for this pull request, visit the following URL:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #813 +/- ##
===========================================
+ Coverage 94.50% 95.17% +0.67%
===========================================
Files 1035 1104 +69
Lines 33299 36340 +3041
Branches 9824 10850 +1026
===========================================
+ Hits 31468 34586 +3118
+ Misses 699 673 -26
+ Partials 1132 1081 -51
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on06dbc7b. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit 06dbc7b was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- medium: CRLF line endings misclassify managed closing references —
src/domain/pull_request_closing_reference.ts:26
Bugbot: review complete
|
Copilot approval · Human review neededStatus: A protected workflow, policy, or trust-boundary file changed. Technical evidenceRevision: |
|
/copilot recheck |
Description replacement could remove a valid
Closesreference when the model returned a false closing flag. The resulting body no longer satisfied approval's textual linkage check even when the managed issue relationship remained intact.The description workflow now preserves explicit closing intent in the portion it replaces, bound to the same repository, distinct PR/issue identity and exact branch issue. A shared Markdown/source policy also replaces approval's anywhere-in-body regex. Code, quotes, comments, escaped/entity spellings, contextual mentions, unrelated references, staged
Refs, missing body and temporary linkage metadata cannot authorize closing evidence. Strict response validation, output limits, stale head/base/body guards, protected paths and all approval evidence gates remain intact.Closes #803.
Added 62 regression cases across pure reference policy, strict rendering, description modes/retries and the actual provider-bound publication/configuration/approval path. Controlled integration tests preserve configuration and native-relation snapshots, exercise protected-path/scope decisions and submit no native approval. Private consumer history was read only; no consumer execution or mutation is claimed. The already-installed
commonmark0.31.2 is classified as a bundled runtime dependency without changing its resolved version. No new query, permission or public setting.Validation: 265 focused tests and 295 related regression tests pass. The new domain policy, presentation and description workflow reach 100% all metrics; local added-code auditing finds no missing statement or branch. Type, lint, specification/catalog, documentation and workflow validation pass. The mandatory full hook passes 812 suites / 15,413 tests (35 existing skips), build and lint. The installed npm archive passes CLI, typed Bugbot API and isolated local-web-session smoke checks; committed bundles validate. Fresh exact-head CI/native/Codecov and zero-active-finding review results remain required before merge.