Repository navigation
fix: reject incomplete SDD catalog discovery for symlinks - #815
Merged
efraespada merged 1 commit intoOct 30, 2026
Conversation
…ation-symlinks: reject symbolic links during specification discovery
|
To preview the documentation for this pull request, visit the following URL:
|
vypbot
self-requested a review
October 30, 2026 18:51
1 task done
Contributor
Bugbot: review complete
|
Contributor
Copilot approval · Human review neededStatus: A protected workflow, policy, or trust-boundary file changed. Technical evidenceRevision: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #815 +/- ##
===========================================
+ Coverage 94.50% 95.17% +0.67%
===========================================
Files 1035 1104 +69
Lines 33299 36348 +3049
Branches 9824 10852 +1028
===========================================
+ Hits 31468 34594 +3126
+ Misses 699 673 -26
+ Partials 1132 1081 -51
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specification catalog discovery now rejects every encountered symbolic link under
specs/without following it. This prevents validation or generation from silently treating an incomplete tree as complete, and avoids publishing a catalog when discovery encounters a link.What changed
discoverSpecificationFileshelper returns a sorted list for supported trees and throws when discovery encounters a symbolic link.Validation
Closes #804