Repository navigation
fix: Review false positive implicit null input requiredness contradicts the actual Kotlin decoder (#807) - #818
Merged
Conversation
…tradicts-the-actual-kotlin-decoder: ground Kotlin Json input omission
|
To preview the documentation for this pull request, visit the following URL:
|
vypbot
self-requested a review
October 30, 2026 20:48
1 task done
Contributor
Bugbot: review complete
|
Contributor
Copilot approval · Human review neededStatus: A protected workflow, policy, or trust-boundary file changed. Technical evidenceRevision: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #818 +/- ##
===========================================
+ Coverage 94.50% 95.17% +0.67%
===========================================
Files 1035 1104 +69
Lines 33299 36347 +3048
Branches 9824 10852 +1028
===========================================
+ Hits 31468 34593 +3125
+ Misses 699 673 -26
+ Partials 1132 1081 -51
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An omitted nullable Kotlin property without a default is accepted when the active Json instance uses explicitNulls=false. The current review baseline incorrectly rejected that input. Ground requiredness in the actual instance and inherited flags, with defaults evaluated before nullable/explicitNulls rules, and return no finding for accepted input. The consumer generator remains unchanged.
Add eight frozen owned cases for both flags, defaults, non-nullable omissions, inheritance, a different active instance and unavailable configuration. The 24 new deterministic cases cover observations, scorer controls, ordinary/partitioned/benchmark delivery and inert-input/privacy boundaries. Preserve all preceding 126 cases and thresholds; update the owner SDD, catalog and documentation together. Equivalent context/locale/finding-field framing preserves the existing 15,000-character limit.
Validation:
Actual model evidence is retained completely in quality/bugbot/evidence/issue-807.json. The baseline has one false positive; V1 and V2 are rejected with one and two respectively. On the same frozen inputs/model/effort, selected V3 has zero false positives/negatives and matches all three genuine defects. Its exact locations are 2/3, below the unchanged 0.8 floor: this bounded sample does not pass all model-quality gates or guarantee future accuracy. No identical-prompt reruns or label/threshold changes are used to obtain green. Perfect reference predictions are separate scorer inputs.
Read-only consumer evidence distinguishes declared serialization 1.6.3, public Ktor 3.0.2's transitive request for 1.7.3, and the independently unknown consumer resolution. No private source or raw consumer log is published, and no consumer code, check or review thread is modified.
Closes #807