Skip to content

fix: Pre branch SDD missing trusted catalog is hidden behind generic workflowfailed and retry guidance (#808) - #821

Merged
efraespada merged 1 commit into
developfrom
bugfix/808-pre-branch-sdd-missing-trusted-catalog-is-hidden-behind-generic-workflow-failed-and-retry-guidance
Oct 30, 2026
Merged

efraespada merged 1 commit into
developfrom
bugfix/808-pre-branch-sdd-missing-trusted-catalog-is-hidden-behind-generic-workflow-failed-and-retry-guidance

Conversation

@efraespada

@efraespada efraespada commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

When specs/catalog.json is absent from the trusted base, pre-branch SDD preparation used to report generic workflow.failed and retry guidance. Confirm absence with a bounded immutable Git tree lookup, then publish a typed configuration.unsupported prerequisite diagnostic with the trusted revision and reviewed merge/synchronization recovery.

Use the existing source-freshness fence and owned status upsert before publishing the EN/ES card. A candidate copy cannot replace the pinned source. Genuine Git read/object failures, malformed existing catalogs and missing support files retain their separate failure paths. Missing-catalog preparation performs no model analysis or branch/specification publication and retains issue/branch state.

Validation:

  • 35 reserved regression cases; seven focused suites pass 395 tests with one pre-existing platform-only skip. The new pure fact, message catalogs and status renderer have 100% coverage. Every added runtime statement and branch is hit.
  • An independent owned Git probe now returns the missing-catalog type with its actual commit; an unknown object remains Error 128. Actual EN/ES renderer previews include the trusted SHA without raw Git commands. These probes do not execute consumer code or publish live issue comments.
  • Types, lint, docs, workflow/agent-doc contracts, specification/catalog generation, Graphify and build pass. npm-package validation and isolated CLI/API/web smoke pass. Full normal commit hooks pass build, all 816 suites / 15,512 tests (35 pre-existing skips), and lint. Committed bundles validate and match the verified source/build identity.

Update the owning SDD, catalog and prerequisite/error-recovery documentation together. The new recovery carries no untrusted operands, and the renderer withholds forged recovery data while validating its closed source fact.

Closes #808

…neric-workflow-failed-and-retry-guidance: diagnose missing trusted catalog
@docs-page

docs-page Bot commented Oct 30, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~821

Documentation is deployed and generated using docs.page

@vypbot vypbot changed the title Report missing trusted SDD catalogs with actionable recovery (#808) fix: Pre branch SDD missing trusted catalog is hidden behind generic workflowfailed and retry guidance (#808) Oct 30, 2026
@vypbot
vypbot self-requested a review October 30, 2026 21:34
@vypbot vypbot added the size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. label Oct 30, 2026
@vypbot vypbot added this to vypdev Oct 30, 2026
@vypbot vypbot moved this to In Progress in vypdev Oct 30, 2026
@vypbot
vypbot changed the base branch from develop to master October 30, 2026 21:34
@vypbot
vypbot changed the base branch from master to develop October 30, 2026 21:35
@vypbot vypbot added the 85% Progress: 85% label Oct 30, 2026
@vypbot

vypbot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on 7ae2878.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: 7ae2878bae22; base: 65f10a28f7a1; reason: protected-path.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.17%. Comparing base (5b3664f) to head (7ae2878).
⚠️ Report is 113 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #821      +/-   ##
===========================================
+ Coverage    94.50%   95.17%   +0.67%     
===========================================
  Files         1035     1105      +70     
  Lines        33299    36365    +3066     
  Branches      9824    10858    +1034     
===========================================
+ Hits         31468    34611    +3143     
+ Misses         699      673      -26     
+ Partials      1132     1081      -51     
Files with missing lines Coverage Δ
...tion/policies/application_error_message_catalog.ts 100.00% <ø> (ø)
...cation/policies/sdd_preparation_message_catalog.ts 100.00% <ø> (ø)
...lication/policies/sdd_preparation_status_policy.ts 100.00% <100.00%> (ø)
...ation/usecases/sdd/pre_branch_sdd_gate_use_case.ts 93.77% <100.00%> (+0.07%) ⬆️
src/data/model/application_error.ts 100.00% <ø> (ø)
src/domain/sdd_trusted_catalog_failure.ts 100.00% <100.00%> (ø)
...infrastructure/pre_branch_sdd_workspace_adapter.ts 77.87% <100.00%> (+0.29%) ⬆️

... and 159 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@efraespada
efraespada merged commit a48473f into develop Oct 30, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

85% Progress: 85% size: XXL Indicates an extremely large task or issue that requires significant time and effort to complete. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Pre branch SDD missing trusted catalog is hidden behind generic workflow.failed and retry guidance

3 participants