Skip to content

fix: provide actionable bounded SDD repair feedback - #854

Merged
efraespada merged 2 commits into
developfrom
bugfix/833-pre-branch-sdd-assembly-rejects-an-undefined-requirement-after-the-bounded-repair-on-a-resolved-ui-feature
Nov 2, 2026
Merged

efraespada merged 2 commits into
developfrom
bugfix/833-pre-branch-sdd-assembly-rejects-an-undefined-requirement-after-the-bounded-repair-on-a-resolved-ui-feature

Conversation

@efraespada

@efraespada efraespada commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

The existing bounded SDD regeneration now receives normalized structural coordinates for rejected drafts, helping it address invalid requirement links and uncovered goals while preserving resolved requirements. Strict validation and publication safeguards remain in force.

What changed

  • Provide the existing single repair attempt with normalized validation facts and row/count coordinates, without including rejected draft text or identifiers.
  • Report the first case row with an undefined requirement and the first uncovered requirement row while retaining the aggregate coverage failure.
  • Distinguish derived-table slot occurrence errors from invalid visible placement, and document the updated repair behavior.

Validation

  • 21 added cases pass; 18 fail against unchanged source, while three compatibility controls already pass. The directed compatibility campaign passes 419 tests.
  • Full coverage passes: 844 Jest suites and 16,320 tests, plus 267 baseline extension tests. All four modified runtime modules report 100% statements, branches, functions, and lines.
  • Local LCOV against 9d39157 reports 22/22 modified coverable lines fully covered with zero misses or partials. Types, lint, specification and documentation checks, build, package validation, and CLI/API/local-web smoke checks pass.

Review notes

Closes #833

…fter-the-bounded-repair-on-a-resolved-ui-feature: provide bounded structural feedback to SDD regeneration
@docs-page

docs-page Bot commented Nov 2, 2026

Copy link
Copy Markdown

To preview the documentation for this pull request, visit the following URL:

docs.page/vypdev/copilot~854

Documentation is deployed and generated using docs.page

@vypbot vypbot added size: XL Indicates that the issue or task is extra large in scope and complexity. state:ai-processing labels Nov 2, 2026
@vypbot
vypbot self-requested a review November 2, 2026 11:20
@vypbot vypbot added this to vypdev Nov 2, 2026
@vypbot vypbot moved this to In Progress in vypdev Nov 2, 2026
@vypbot vypbot added the 70% Progress: 70% label Nov 2, 2026
@vypbot
vypbot changed the base branch from develop to master November 2, 2026 11:21
@vypbot
vypbot changed the base branch from master to develop November 2, 2026 11:21
@vypbot

vypbot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Bugbot: review complete

Current status: No active findings on f46c2ce.

Pull request · Verified commit · Workflow run

@vypbot

vypbot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Copilot approval · Human review needed

Status: A protected workflow, policy, or trust-boundary file changed.
Completed: 1/1 observed checks succeeded; Bugbot complete.
Action required: Ask a human reviewer to decide.
Impact: No new approval is confirmed for this revision.
See checks

Technical evidence

Revision: f46c2ce4bed8; base: 9d3915729c96; reason: protected-path.

@codecov-commenter

codecov-commenter commented Nov 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.29%. Comparing base (9d39157) to head (f46c2ce).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #854   +/-   ##
========================================
  Coverage    95.29%   95.29%           
========================================
  Files         1125     1125           
  Lines        37170    37180   +10     
  Branches     11092    11095    +3     
========================================
+ Hits         35422    35432   +10     
  Misses         672      672           
  Partials      1076     1076           
Files with missing lines Coverage Δ
...cation/policies/sdd_preparation_message_catalog.ts 100.00% <ø> (ø)
...tion/usecases/sdd/pre_branch_sdd_draft_workflow.ts 100.00% <100.00%> (ø)
src/domain/sdd_draft_consistency.ts 100.00% <100.00%> (ø)
src/domain/sdd_validation_diagnostic.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…fter-the-bounded-repair-on-a-resolved-ui-feature: require explicit SDD consistency facts
@efraespada
efraespada merged commit 9abb788 into develop Nov 2, 2026
13 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in vypdev Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

70% Progress: 70% size: XL Indicates that the issue or task is extra large in scope and complexity. state:verified

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

🐛🧑‍💻 - Pre branch SDD assembly rejects an undefined requirement after the bounded repair on a resolved UI feature

3 participants