Skip to content

End-to-end tests lack coverage for deducting impression site quotas #454

Description

@apasel422

All the current tests still pass if this block is commented out:

for (const impression of impressions) {
const impressionSite = impression.impressionSite;
const impressionQuotaKey = { site: impressionSite, epoch };
const entryI = getOrInsertEntry(
this.#impressionSiteQuotaStore,
impressionQuotaKey,
this.#delegate.impressionSiteQuotaPerEpoch,
);
if (
getEntry(deductedImpressionQuotas, impressionQuotaKey) === undefined
) {
deductedImpressionQuotas.push(impressionQuotaKey);
entryI.value -= valueDeduction;
}
}

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions