Repository navigation
Method name for setting a CRS #3
Description
Several options:
.proj.set_crs(...): like in Xvec and currently implemented.proj.write_crs(...): like in rioxarray.proj.assign_crs(...): like in odc-geo
I have a slight preference for option 3. This is more consistent with methods like Xarray assign_coords that also return new Dataset or DataArray objects with new or replaced coordinates.
Activity
scottyhq commentedon Dec 4, 2024
I agree! Would be great to align as much as possible with existing Xarray methods and syntax
benbovy commentedon Dec 5, 2024
I also wonder whether we should have a
allow_override=Falseoption or no option, i.e., in the latter case just leave the responsibility to the user thatassign_crs(spatial_ref=crs)may overwrite any existing CRS.odc-geo's
assign_crs()docstrings says "Assign CRS for a non-georegistered array or dataset" but I don't see anything that prevent overwriting an existing CRS in the implementation.