No longer possible to use an executable in PATH for lsp implementation

[xyven1]

The Problem

When lsp_binary was used to pass in the binary to use for the LSP implementation, it was possible to simply pass in executable find-able in PATH. With the new server and custom_server_filepath options, there is no direct way (that I can see) to have this plugin simply execute some binary which exists in PATH. For me this is a regression, since this is the only way I expect binaries to be reachable (via PATH, and not an absolute path).

Potential Solution

Provide a different option for the server which simply allows for users to specify the name of an executable. For example:

require("copilot.lua").setup({
    server = {
        type = "executable",
        name = "copilot-lsp"
    }
})

Workaround

require("copilot.lua").setup({
    server = {
        type = "binary",
        custom_server_filepath = vim.fn.exepath('copilot-lsp')
    }
})

This workaround is fairly simple, and so I wouldn't hate having to rely on it, but seems like this functionality should be exposed by the default set of options.

[AntoineGS]

Good point, @aymanbagabas raised the same request in another thread today.
I will be adding the feature :)

[xyven1]

Appreciate it!

[AntoineGS]

Let me know if you run into any issues! Turned out to be verrry simple, just put 'copilot-lsp' in the custom-server-filepath config. It will honor either executables that are accessible by PATH or absolute filepaths.

[xyven1]

I'll give it a shot tonight

[xyven1]

Yeah, that PR returns the behavior I would expect. Thanks!