make sure to use node on js file - #23
Closed
Chanakan5591 wants to merge 1 commit into
Closed
Conversation
Owner
|
Technically I already implemented (and later fixed!) overriding the command so that windows users can do so, but since passing node as an additional arg works fine on all systems I'll just do that without a check. While normally I am happy to take contributions, to be honest the code here is a bit redundant and the fix is pretty easy so I'll just merge it myself. Thank you for pointing this out to me though, and I wish you luck learning lua! Just for your reference, if the check were necessary the way you would probably want to do this is just by changing the main statement to be the following: |
Author
|
I learnt new thing about lua today, thanks for that :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A very simple fix for this to work on Windows. Since windows don't understand shebang, we need to make sure it use node from the Path environment variable. (There might be a better way to do this but I'm pretty new to Lua)