Skip to content

Update action's node version - #392

Closed
Jamie Neubert Pedersen (eikooc) wants to merge 2 commits into
Azure:masterfrom
eikooc:update-node-version
Closed

Update action's node version#392
Jamie Neubert Pedersen (eikooc) wants to merge 2 commits into
Azure:masterfrom
eikooc:update-node-version

Conversation

@eikooc

@eikooc Jamie Neubert Pedersen (eikooc) commented Dec 28, 2023

Copy link
Copy Markdown

References these issues:
#357
#391

@vRune4

Copy link
Copy Markdown

This update is probably not complete.

E.g. .github/workflows/azure-login-positive.yml contains this:

    - name: Set Node.js 16.x for GitHub Action
      uses: actions/setup-node@v4
      with:
        node-version: 16.x

I suspect the tests will have to be updated as well.

@eikooc

Copy link
Copy Markdown
Author

Rune Moberg (@vRune4) the mentioned code is not the action's version, but the version of an action this repository uses actions/setup-node@v4 for it's CI pipeline.

@MoChilia

Copy link
Copy Markdown
Member

Thanks a lot for your contribution, the change is merged in #411.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants