Update Action to use Node.js v20

[Justin Chao (j-chao)]

Node.js 16 actions are deprecated.
Updating action to use Node.js 20.

Link: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/

Fixes #357

[Justin Chao (j-chao)]

Yan Xu (@YanaXu) Shiying Chen (@MoChilia)
Any objections to getting this Action updated to using Node.js 20?

[Yan Xu (YanaXu)]

Hi Justin Chao (@j-chao) , we do want to upgrade the node version, together with other old node module versions. But it's not a easy update. It asks for full tests and all necessary checks. We'll keep this PR open for a reminder. Thanks for your work.

[Bharat Meena (bharatatDisys)]

Changes are not significant . Can be merged without breaking.

[Marko Kohtala (kohtala)]

Usually packages just open a new major when a node version support is removed. That way users know it can break something and can avoid unintentional upgrades.

[Jamie Neubert Pedersen (eikooc)]

There is already an open PR with this change here #392

[Florent Tatard (FlorentATo)]

This PR seems incomplete Justin Chao (@j-chao): https://github.com/search?q=repo%3AAzure%2Flogin%2016.x&type=code

[Jamie Neubert Pedersen (eikooc)]

Florent Tatard (@FlorentATo) I've explained the same comment in another PR in a comment. Those node versions don't have anything to do with this action's node version. It is their own workflows and they can be updated independently as they are not used by the action when you run the action in your repo.

[Marko Kohtala (kohtala)]

Those node versions don't have anything to do with this action's node version. It is their own workflows and they can be updated independently as they are not used by the action when you run the action in your repo.

Jamie Neubert Pedersen (@eikooc) There are some npm run test that should run with the same version that is going to be used to run the action when released. I see some integration tests are run by executing the action, so those parts do use the node20 to test it, but I expect the unittests would cover some additional cases.

[Justin Chase (justinmchase)]

Justin Chao (@j-chao) Can you update the below lines of code as well?

Basically search for 16.x and replace with 20.x

• https://github.com/Azure/login/blob/master/.github/workflows/azure-login-negative.yml#L27
• https://github.com/Azure/login/blob/master/.github/workflows/azure-login-negative.yml#L90
• https://github.com/Azure/login/blob/master/.github/workflows/azure-login-negative.yml#L351
• https://github.com/Azure/login/blob/master/.github/workflows/azure-login-positive.yml#L26
• https://github.com/Azure/login/blob/master/.github/workflows/azure-login-positive.yml#L122
• https://github.com/Azure/login/blob/master/.github/workflows/azure-login-positive.yml#L262
• https://github.com/Azure/login/blob/master/.github/workflows/azure-login-pr-check.yml#L23
• https://github.com/Azure/login/blob/master/.github/workflows/ci.yml#L26
• https://github.com/Azure/login/blob/master/.github/workflows/markdownlint.yml#L14

[Justin Chao (j-chao)]

@microsoft-github-policy-service agree

[Andrew (AndrewEhlo)]

When using an updated to node20 version got the error

Did anyone face it too?
Shiying Chen (@MoChilia) Justin Chase (@justinmchase)
Seems like lib folder has been excluded from the action in recent versions:

[Shiying Chen (MoChilia)]

Hi Andrew (@AndrewEhlo), please avoid running azure/login from the master branch. The built files will be only included in the release branch. Kindly wait for the new release. Thank you.

[Jochem van den Ende (JochemE)]

Hi Shiying Chen (@MoChilia), do you have an idea on when this will be released?
Expected release is March 👍
#420 (comment)