Skip to content

Use buf_set_lines & buf_set_text methods instead of nvim.current.line - #9

Merged
gptlang merged 2 commits into
CopilotC-Nvim:mainfrom
ziontee113:use_buf_set_lines
Jan 4, 2024
Merged

Use buf_set_lines & buf_set_text methods instead of nvim.current.line#9
gptlang merged 2 commits into
CopilotC-Nvim:mainfrom
ziontee113:use_buf_set_lines

Conversation

@ziontee113

Copy link
Copy Markdown
Contributor

This PR uses buf_set_lines & buf_set_text methods to append new tokens to the end of the chat buffer, no matter which window is active and no matter the user's current cursor position.

This makes moving the cursor / changing window mid generation possible without new tokens spewing out at the current cursor position.

@jellydn

jellydn commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

Nice job 👏
@gptlang I was about to report the issue then I saw this PR. This is working nicely. Could you take a look? Thanks.

jellydn added a commit to jellydn/CopilotChat.nvim that referenced this pull request Jan 3, 2024

@gptlang gptlang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gptlang
gptlang merged commit 2a04683 into CopilotC-Nvim:main Jan 4, 2024
jellydn added a commit to jellydn/CopilotChat.nvim that referenced this pull request Jan 19, 2024
* chore: sync fork

* feat: add option to change view mode

* chore: sync the change from CopilotC-Nvim#9

* docs: add new usage to canary branch

fix: typo on usage

* chore: sync fork

chore: sync the fork

chore: sync fork

chore: sync fork

* feat: add spinner

* feat: show spinner on processing

* chore: sync fork
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants