This repository was archived by the owner on Feb 5, 2024. It is now read-only.
Conversation
|
Apply Sweep Rules to your PR?
|
jellydn
force-pushed
the
canary
branch
2 times, most recently
from
January 9, 2024 05:03
ad89f83 to
b23bf17
Compare
chore: sync the fork chore: sync fork chore: sync fork
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
| role: str | ||
|
|
||
|
|
||
| @dataclass |
There was a problem hiding this comment.
Suggested change
| @dataclass | |
| @dataclass(frozen=True) |
Use frozen=True to make the dataclasses immutable and hashable. More.
Comment on lines
+68
to
+72
| f.write( | ||
| json.dumps( | ||
| { | ||
| "github.com": { | ||
| "user": user, |
There was a problem hiding this comment.
Suggested change
| f.write( | |
| json.dumps( | |
| { | |
| "github.com": { | |
| "user": user, | |
| json.dump( | |
| }, | |
| f) | |
This can be simplified by using json.dump(...). More.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
WHY
HOW
Screenshots (if appropriate):
Types of changes
Checklist: