Skip to content

Support native google-java-format executables #17

Closed

Description

@vorburger

In google/google-java-format#1045 I'm working on making "native" (non java -jar google-java-format*.jar) binaries available. If that's accepted, those should start to appear on https://github.com/google/google-java-format/releases in the future.

It will initially be for Linux only; perhaps Mac and Windows (will be contributed by others) later.

It would be very cool if this VSC extension could check if it runs on a platform for which a native binary is available, and download and invoke that! (Once it's available for download, of course.)

Activity

  1. self-assigned this
    on Feb 18, 2024
  2. linked a pull request that will close this issueAlpha #19on Feb 18, 2024
  3. added a commit that references this issue on Feb 18, 2024
  4. github-actions commented on Feb 18, 2024

    @github-actions

    🎉 This issue has been resolved in version 1.1.0 🎉

    The release is available on:

    Your semantic-release bot 📦🚀

  5. JoseVSeb commented on Feb 18, 2024

    @JoseVSeb
    Owner

    @vorburger I have verified the native binary is executed correctly in windows and wsl. can you verify it on mac?

  6. vorburger commented on Feb 18, 2024

    @vorburger
    ContributorAuthor

    @vorburger I have verified the native binary is executed correctly in windows and wsl. can you verify it on mac?

    Thanks for implementing this so fast!

    I have just verified it on Linux and the DL works great - it would only need #20 to "just work out of the box".

    For Mac the binary should be OK, because I know that a work colleague of mine (@cushon) has tested and fixed it, but I think it may need the same missing chmod +x after you download it as on Linux (#20).

    I've posted about how I'm happy to have enabled this:

    "Formatting completed in 45ms." instead of 473ms previously...

    That x10 is actually noticeable on Ctrl-S Save a *.java, even on a fast computer - very cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions