Repository navigation
fix: CI pipeline, test infrastructure, and code quality improvements - #801
Merged
Merged
Conversation
ismisepaul
force-pushed
the
fix-java-formatting
branch
from
March 28, 2026 22:44
3024404 to
169648d
Compare
Apply Google Java Format to 33 files with pre-existing formatting issues. Add JDK 24 setup to lint-java job — the latest GJF downloaded by the action requires JDK 23+ (uses JCTree$JCAnyPattern) but the ubuntu-latest runner only has JDK 21. Made-with: Cursor
ismisepaul
force-pushed
the
fix-java-formatting
branch
from
March 28, 2026 22:47
169648d to
f7496c6
Compare
Remove accidentally committed files from git tracking: - 2,022 auto-generated build outputs from ReverseEngineer3/app/build/ - 25 Eclipse workspace files from MobileShepherd/.metadata/ Update root .gitignore with comprehensive entries for Gradle, IntelliJ, Eclipse, macOS, and log files to prevent re-committing. Made-with: Cursor
The standalone docker-compose v1 binary was removed from the ubuntu-latest GitHub Actions runner. Use the Docker CLI plugin syntax (docker compose) instead. Made-with: Cursor
The ubuntu-latest runner now uses Ubuntu 24.04 (Noble) where the package was renamed from libargon2-0 to libargon2-1. Made-with: Cursor
- Remove serial needs dependencies so all 4 jobs (lint, build, unit-tests, integration-tests) run in parallel - Add Maven dependency caching via setup-java cache: maven - Update actions/checkout v2 → v4 and actions/setup-java v1 → v4 - Remove -X debug flag from unit test Maven invocation Made-with: Cursor
TestCountdownHandler used @BeforeClass (JUnit 4) with @test (JUnit 5), so the setup method was silently ignored and database.properties was never created. Convert to @BeforeAll and JUnit 5 assertion imports. Also add missing createMongoResource() call in MongoDatabaseTest setup so mongo.properties exists for tests that read connection config. Made-with: Cursor
GetterTest, SetterTest, MongoDatabaseTest, and TestCountdownHandler all require MySQL/MongoDB infrastructure but were classified as unit tests under src/test/java/. Move them to src/it/java/ with IT suffix naming so Maven Failsafe runs them during integration-test phase. - GetterTest → GetterIT (src/it/java/dbProcs/) - SetterTest → SetterIT (src/it/java/dbProcs/) - MongoDatabaseTest → MongoDatabaseIT (src/it/java/dbProcs/) - TestCountdownHandler → CountdownHandlerIT (src/it/java/testUtils/) - Update all 20 IT files referencing the old class names - Remove MySQL service from CI unit-tests job (only true unit test remaining is TestXmlDocumentBuilder which needs no infrastructure) Made-with: Cursor
Add 9 new test files and expand TestXmlDocumentBuilder coverage, bringing the unit test count from 1 to 153. All tests are true unit tests with no external dependencies (DB, filesystem, network). New tests cover SqlFilter, XssFilter, Validate, OneTimePad, FindXSS, UserKicker, Hash, ModuleBlock, and GetJson. Made-with: Cursor
String.repeat() is a Java 11+ API. The project targets JDK 8, so CI compilation fails. Use a char-array fill helper instead. Made-with: Cursor
…seIT CountdownHandlerIT had wrong expectations that didn't match the actual CountdownHandler semantics: - disableStartTime means "always started", not "not started" - isOpen is false when locked (lock time in the past) - isRunning ignores lock state by design MongoDatabaseIT fixes: - Add missing mongo_challenge_test.properties test fixture - Add build-helper add-test-resource for src/it/resources classpath - Replace Hamcrest assertions with JUnit 5 assertInstanceOf - Disable Fongo-dependent tests (incompatible with mongo-java-driver 3.12) Also update CONTRIBUTING.md with Google Java Format CI enforcement details and formatting instructions. Made-with: Cursor
ismisepaul
changed the title
Made-with: Cursor
- Remove dependency-check.yml (redundant with Dependabot security alerts) - Expand dependabot.yml to cover github-actions and docker ecosystems - Add dependency-review job to test.yml to block PRs with critical vulns Made-with: Cursor
This was referenced May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Code formatting & linting
lint-javaCI action to v4 (Node 20) with JDK 24 for GJF 1.35.0 compatibilitysrc/MobileShepherd/ReverseEngineer3/app/build/.gitignorewith comprehensive patterns for Maven, Gradle, IDE, and OS filesCONTRIBUTING.mdCI pipeline fixes
docker-composewithdocker compose(v2 syntax)libargon2-0tolibargon2-1for Ubuntu 24.04 runnerslint-java,build,unit-tests,integration-tests)unit-testsjob (no longer needed)Dependency management
dependabot.ymlto also covergithub-actionsanddockerecosystems (weekly)dependency-reviewjob to PR workflow to block PRs introducing critical vulnerabilitiesTest infrastructure refactoring
GetterTest,SetterTest,MongoDatabaseTest,TestCountdownHandlerfrom unit tests (src/test) to integration tests (src/it) with proper*ITnaming*Test) and Failsafe (integration*IT) properly*ITclass namesNew unit tests (153 tests total)
SqlFilterTest— 14 tests for SQL filter levels 1-4XssFilterTest— 17 tests for XSS filter levels and HTML encodingValidateTest— 30 tests for input validation utilitiesOneTimePadTest— 9 tests for encrypt/decrypt round-tripsFindXSSTest— 22 tests for XSS detection and CSRF validationUserKickerTest— 6 tests for user kick list managementHashTest— 14 tests for HMAC generation and random stringsModuleBlockTest— 7 tests for module blocking utilitiesGetJsonTest— 6 tests for JSON array parsingTestXmlDocumentBuilder— expanded from 1 to 6 testsIntegration test fixes
CountdownHandlerIT— corrected 8 assertions to match actualCountdownHandlersemantics (disabled start = always started;isOpenrespects lock state;isRunningignores lock state)MongoDatabaseIT— add missingmongo_challenge_test.propertiesfixture, replace Hamcrest with JUnit 5 assertions, disable Fongo-dependent tests (incompatible with mongo-java-driver 3.12.14)Test plan
lint-javaCI job passesbuildCI job passesunit-tests— 153 tests pass (0 failures)integration-tests— CountdownHandlerIT and MongoDatabaseIT fixes verifieddependency-review— new job runs on PRs