You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@dgadelha
Breaking changes do not belong in patch releases. This should have been postponed for next major or the typing introduced in a non-breaking way like I mentioned above with a good default.
@hakimio I'm with you! I just pointed out that the author of the PR explicitly mentioned this was a breaking change, yet it was still released as a patch version. I’ve updated my comment to make that clearer :)
Jumping in again, this is introducing type errors in our codebase where there were none previously. This is absolutely a breaking change and should've been included in a major version bump, along with guidance on how to remediate.
Reacted by Tim Fechner, Tomas Rimkus, Burhan Ali, Yong, chris, Gabor Varadi, Hudimod, Tiago Eusébio and Addison Emig
Yep, and the docs are incorrect at the moment, as they still mention usage of next() with no parameters, which is no longer allowed: https://rxjs.dev/guide/subject#void-subject
We also experienced the breaking changes in our project.
Activity
hakimio commentedon Mar 4, 2025
I guess now you have to explicitly specify the generic type:
Either the default generic should be set to
void(class Observable<T = void>) for theObservableor this breaking change should be postponed untilv8.dgadelha commentedon Apr 7, 2025
The changelog mentions this as part of the 7.8.2 patch release:
Whereas the PR explicitly has on the description:
Yet, it was released in a patch version.
hakimio commentedon Apr 7, 2025
@dgadelha
Breaking changes do not belong in patch releases. This should have been postponed for next major or the typing introduced in a non-breaking way like I mentioned above with a good default.
dgadelha commentedon Apr 7, 2025
@hakimio I'm with you! I just pointed out that the author of the PR explicitly mentioned this was a breaking change, yet it was still released as a patch version. I’ve updated my comment to make that clearer :)
samwightt commentedon May 13, 2025
Jumping in again, this is introducing type errors in our codebase where there were none previously. This is absolutely a breaking change and should've been included in a major version bump, along with guidance on how to remediate.
SvetlaGeorgieva commentedon Nov 27, 2025
Yep, and the docs are incorrect at the moment, as they still mention usage of
next()with no parameters, which is no longer allowed: https://rxjs.dev/guide/subject#void-subjectWe also experienced the breaking changes in our project.