Repository navigation
Options.ignore changed type from 8.0.1 to 8.0.2 #1063
Description
Activity
- What's your use-case? Is this causing you trouble on a project?…On Tue, Jun 2, 2020, 7:08 AM Simon Hanna ***@***.***> wrote: Previously (ts-node 7.x.x) options.ignore used to be a string | string[] and it continued to be supported in 8.0.0. However in 8.0.2 it was changed to only accept string The breaking change is this commit 0db041f <0db041f> The current types only allow an array, but the docs say that the default is a string https://github.com/TypeStrong/ts-node/blob/master/src/index.ts#L171 Can we bring back string | string[]? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1063>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAC35OHZZTJKFVZ7L3JYHETRUTMRLANCNFSM4NQT7BDQ> .
The commit you pointed out doesn’t change the input type of the option. Also, as far as I can see in both that commit and master, it accepts only an array of strings.
To clarify, the contract this module follows is what is documented (usually in the type system). In this case the breaking change was an undocumented use case that wouldn’t compile in typescript. Happy to update the README to match correctly, but I don’t see where it says it accepts a string there.
Previously (ts-node 7.x.x) options.ignore used to be a
string | string[]and it continued to be supported in 8.0.0.However in 8.0.2 it was changed to only accept
stringThe breaking change is this commit 0db041f
The current types only allow an array, but the docs say that the default is a string
https://github.com/TypeStrong/ts-node/blob/master/src/index.ts#L171
Can we bring back
string | string[]?