Skip to content

ignore option docs unclear; should point out they're regexps #1089

Open
Open
ignore option docs unclear; should point out they're regexps#1089
Labels
documentationyou can do thisGood candidate for a pull request.

Description

@cspotcode
cspotcode
opened on Jul 29, 2020

It's not clear that the ignore option is an array of regexps which are passed to new RegExp. I think we can be clearer about this.

Whatever docs update we make for this will also address #1063

EDIT: also the schema default value is wrong. Default is a string but should be an array.

Activity

  1. cspotcode
    added
    documentation
    on Aug 10, 2020
  2. cspotcode
    added
    you can do thisGood candidate for a pull request.
    on Oct 13, 2021

  3. panchoroo commented on Oct 13, 2022

    @panchoroo
    panchoroo
    on Oct 13, 2022

    Is this issue still open? Is it referring to this documentation here: https://github.com/TypeStrong/ts-node/blob/main/README.md#ignore-by-regexp?

  4. andrewmedhurst commented on Oct 15, 2023

    @andrewmedhurst
    andrewmedhurst
    on Oct 15, 2023

    @cspotcode Based on these comments, it would appear that the appropriate documentation has been completed by you in this PR: https://github.com/TypeStrong/ts-node/pull/1155/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80. If there are no additional changes needed to the documentation, it would appear that this issue is safe to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationyou can do thisGood candidate for a pull request.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions