Skip to content

Ability to turn off sourceMap #796

Open

Description

@staeke

There is no way to turn off source maps as of now. See e.g. #27

Source maps are not always desired, and can make debugging a lot harder - see e.g. react/create-react-app#1557

Feature request: allow turning off. Suggested way by respecting tsconfig.json

Activity

  1. blakeembrey commented on Mar 6, 2019

    @blakeembrey
    Member

    What's the use case or issue here? You linked to unrelated things.

  2. staeke commented on Mar 6, 2019

    @staeke
    Author

    @blakeembrey they're related....let me clarify:

    #27 is about how default settings for source maps override any user settings. The person creating the other ticket considered it a bug, but someone stated that sourceMaps should always override user settings anyhow. I think that's bad, but understand that changes elsewhere in code is also needed.

    The create-react-app link is about why people would want to turn off source maps

  3. blakeembrey commented on Mar 6, 2019

    @blakeembrey
    Member

    @staeke You're always welcome to submit a PR that'll add a flag to disable this behavior.

    My question is because it sounds like this is a feature request, but there hasn't been anyone with an issue that warrants this feature. But again, if you'd like to add it, I won't block on that.

  4. rubenlg commented on Dec 12, 2021

    @rubenlg

    Looking forward to this feature. When running ts-node inside electron, source-map-support blows up every time any module attempts to read the stack of an exception, with the following message:

    Uncaught RangeError: WebAssembly.Compile is disallowed on the main thread, if the buffer size is larger than 4KB. Use WebAssembly.compile, or compile on a worker thread.
    
  5. cspotcode commented on Dec 13, 2021

    @cspotcode
    Collaborator

    I recommend checking out #1533 and submitting a pull request. It should solve your problem. #1533 has a low level of effort required for implementation, and I'm happy to answer any questions in the comments for #1533.

  6. rubenlg commented on Dec 13, 2021

    @rubenlg

    I dropped the require that you pointed out in #1533 altogether, and that fixes the issue.
    I suspect the right solution in my case would be to fix the interoperability between source-map-support and electron in the source-map-support module instead, but as a quick workaround, patching ts-node did the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions