Skip to content

refactor(wiki.nixos.org): use mediawiki library module - #1895

Open
uncenter wants to merge 11 commits into
mainfrom
feat/mediawiki-lib-integrate-nixos-wiki
Open

refactor(wiki.nixos.org): use mediawiki library module#1895
uncenter wants to merge 11 commits into
mainfrom
feat/mediawiki-lib-integrate-nixos-wiki

Conversation

@uncenter

@uncenter uncenter commented Sep 8, 2025 •
edited by WalkQuackBack
Loading

Copy link
Copy Markdown
Member

Integrates the new library module for MediaWiki sites from #1866. Must be merged after #1866 is merged into main.

Closes #1864

@github-actions github-actions Bot added the wiki.nixos.org NixOS Wiki label Sep 8, 2025
@uncenter uncenter changed the title feat(lib): add mediawiki lib module refactor(wiki.nixos.org): use mediawiki lib module Sep 8, 2025
@uncenter uncenter changed the title refactor(wiki.nixos.org): use mediawiki lib module refactor(wiki.nixos.org): use mediawiki library module Sep 8, 2025
@uncenter uncenter mentioned this pull request Sep 8, 2025
Merged
@uncenter
uncenter marked this pull request as ready for review September 8, 2025 01:37
@uncenter
uncenter requested a review from orangci as a code owner September 8, 2025 01:37
@uncenter

uncenter commented Sep 8, 2025

Copy link
Copy Markdown
Member Author

@orangci I'd love if you could take a quick look and see if anything is broken. If things look good for the most part I'm going to merge #1866 before rebasing this one and merging it. Just don't merge it yourself yet :)

orangci
orangci previously approved these changes Sep 8, 2025
View reviewed changes

@orangci orangci left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using https://raw.githubusercontent.com/catppuccin/userstyles/b9a7bb8e6ad1d8c11f174afbe4e8394f60bd0eb3/lib/mediawiki.less as the import instead of using https://userstyles.catppuccin.com/lib/mediawiki.less, as that doesn't exist (yet).

Works excellently! Great work on #1866.

I did notice that table cells don't seem to have proper borders.
For an example of this visit https://wiki.nixos.org/wiki/Terms_and_Definitions_in_Nix_Project and try toggling the userstyle off and on.

@uncenter

uncenter commented Sep 8, 2025

Copy link
Copy Markdown
Member Author

Tested using b9a7bb8/lib/mediawiki.less (raw) as the import instead of using userstyles.catppuccin.com/lib/mediawiki.less, as that doesn't exist (yet).

Oops yeah sorry I forgot to mention that, you figured it out anyway ahah.

I did notice that table cells don't seem to have proper borders.
For an example of this visit wiki.nixos.org/wiki/Terms_and_Definitions_in_Nix_Project and try toggling the userstyle off and on.

Thanks. I've adjusted border colors more and I think it's better: a6eda7e (#1866).

@orangci

orangci commented Sep 9, 2025

Copy link
Copy Markdown
Member

Thanks. I've adjusted border colors more and I think it's better: a6eda7e (#1866).

Yep, this is definitely better. I think this PR is now ready to merge as soon as #1866 is merged. 馃А

@uncenter uncenter linked an issue Oct 7, 2025 that may be closed by this pull request
Nix Wiki colors mismatch, #1728
Open
2 tasks
@uncenter uncenter added 4.topic: libraries Relating to the standard library and/or library modules 2.status: pending Pending until internal discussion, planned updates, etc. labels Nov 4, 2025
@WalkQuackBack WalkQuackBack added the 6.by: staff Authored by a staff member label Nov 4, 2025
@ninetailedtori ninetailedtori mentioned this pull request Dec 28, 2025
Closed
16 tasks
@WalkQuackBack WalkQuackBack mentioned this pull request Feb 5, 2026
Open
21 tasks
uncenter and others added 7 commits August 20, 2026 14:51
@uncenter
feat(lib): add mediawiki lib module
344f631
@uncenter
fix(lib/mediawiki): remove site specific styling
65bba2d
@uncenter
refactor(lib/mediawiki)!: nest utilities under namespace
e428514
@uncenter
fix(lib/mediawiki): adjust border colors slightly
95bf89f
@uncenter
fix(lib/mediawiki): adjust borders further
77a5092
@WalkQuackBack @uncenter
feat(lib/mediawiki): use codex style guide (#1962)
eed36f3 
* feat(lib/mediawiki): use codex style guide to base colour choices

* chore(lib/mediawiki): comment nits

* fix(lib/mediawiki): change button quiet hover colours to fade accent

* fix(mediawiki): remove redundant transparent variables

* fix(lib/mediawiki): change tab list framed state colours to latte fade

---------

Co-authored-by: uncenter <uncenter@uncenter.dev>
@uncenter
feat(lib/mediawiki): radio inputs
470d1d4
@uncenter
uncenter force-pushed the feat/mediawiki-lib-module branch from 5642232 to 470d1d4 Compare August 20, 2026 18:52
@uncenter
uncenter force-pushed the feat/mediawiki-lib-integrate-nixos-wiki branch from b0a0c03 to cd857d6 Compare August 20, 2026 19:01
@uncenter uncenter removed the 2.status: pending Pending until internal discussion, planned updates, etc. label Aug 20, 2026
WalkQuackBack
WalkQuackBack previously approved these changes Aug 22, 2026
View reviewed changes

@WalkQuackBack WalkQuackBack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise and from a brief test on the website this looks good to merge once the library module is merged.

Base automatically changed from feat/mediawiki-lib-module to main August 27, 2026 06:06
@WalkQuackBack
WalkQuackBack dismissed stale reviews from orangci and themself August 27, 2026 06:06

The base branch was changed.

@WalkQuackBack WalkQuackBack mentioned this pull request Aug 27, 2026
Open
16 tasks
@uncenter
uncenter requested a review from WalkQuackBack August 31, 2026 13:54
@uncenter

uncenter commented Aug 31, 2026

Copy link
Copy Markdown
Member Author

This LGTM and I'd love to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orangci orangci orangci left review comments
@WalkQuackBack WalkQuackBack Awaiting requested review from WalkQuackBack

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

4.topic: libraries Relating to the standard library and/or library modules 6.by: staff Authored by a staff member wiki.nixos.org NixOS Wiki

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nix Wiki colors mismatch,

3 participants

@uncenter @orangci @WalkQuackBack