fix(wikipedia): recolor {{text diff}} template - #1953
Open
salarua wants to merge 2 commits into
Open
Conversation
* Change --background-color-content-removed and --background-color-content-added vars to use Catppuccin colors * Add rule recoloring .diffchange color to --color-inverted for visibility on colored background; uses !important because every .diffchange element is individually styled inline Fixes: catppuccin#1951
Author
Preview imagesLight themeUnstyled v2025.06.04 v2025.10.07 Dark theme (Mocha)Unstyled v2025.06.04 v2025.10.07 |
uncenter
reviewed
Oct 8, 2025
Member
uncenter
added
the
2.status: pending
uncenter
removed
the
2.status: pending
Member
|
My apologies for the delay. I think we can get this in without waiting for those blocking changes. |
uncenter
reviewed
Dec 29, 2025
Comment on lines
+170
to
+171
| --background-color-content-added: @blue; | ||
| --background-color-content-removed: @yellow; |
Member
There was a problem hiding this comment.
Instead of adding the override for the text color below, we can fade the diff background color to 10-20% as per the style guide (https://github.com/catppuccin/catppuccin/blob/main/docs/style-guide.md#code-editors) and then keep the regular foreground color.
WalkQuackBack
added
0.kind: bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
馃敡 What does this fix? 馃敡
Closes #1951
馃棐 Checklist 馃棐