refactor(wikipedia): use mediawiki library module - #1867
Conversation
4741695 to
bbffca8
Compare
fda035f to
c7a75ec
Compare
bbffca8 to
147fb04
Compare
083513d to
b8c13fd
Compare
|
Can you please provide a reproduction URL? |
|
|
| @@ -278,7 +117,7 @@ | |||
| background-color: @surface2; | |||
| } | |||
There was a problem hiding this comment.
| } | |
| } | |
| .sidebar { | |
| background-color: @surface0 !important; | |
| .sidebar-title { | |
| background-color: inherit !important; | |
| } | |
| .sidebar-list-title { | |
| background-color: @surface1 !important; | |
| } | |
| } |
Fixes sidebar issue, see Wikipedia contribution Help: pages, e.g. https://en.wikipedia.org/wiki/Help:Interlanguage_links
There was a problem hiding this comment.
Seems like there is a specific CSS override for that exact table?
html.skin-theme-clientpref-night .mw-parser-output .linking-and-page-manipulation {
background-color:#101418;
color:white
}
There was a problem hiding this comment.
Hmm, it's rather consistent for all Help pages, though? Are the others tagged the same as well?
There was a problem hiding this comment.
If you could check yourself that would be great, I'm a little spread thin at the moment.
There was a problem hiding this comment.
If you could check yourself that would be great, I'm a little spread thin at the moment.
Confirmed that we need it to be sidebar: see other pages outside of topic: https://en.wikipedia.org/wiki/Wikipedia:Project_namespace#Wikipedia_how-to_and_information_pages, https://en.wikipedia.org/wiki/Wikipedia:Policies_and_guidelines, etc.
There was a problem hiding this comment.
Or, alternatively, [role="navigation"] should be more "specific" if you're worried, as well.
There was a problem hiding this comment.
Confirmed that we need it to be sidebar: see other pages outside of topic: en.wikipedia.org/wiki/Wikipedia:Project_namespace#Wikipedia_how-to_and_information_pages, en.wikipedia.org/wiki/Wikipedia:Policies_and_guidelines, etc.
Those pages use the .help-box class.
Or, alternatively, [role="navigation"] should be more "specific" if you're worried, as well.
I would really like to stick to using the actual classnames on these elements if we could please. There is no need to branch out into attribute selectors here when we can look at how the original CSS does it perfectly well.
There was a problem hiding this comment.
Changed to .help-box.
There was a problem hiding this comment.
NOT certain we should be specifying it with .help-box, tbh. See this: https://en.wikipedia.org/wiki/Wikipedia:Manual_of_Style/Linking#Interwiki_links, where "Manual of Style" sidebar is separate from linking-and-page-manipulation but still sidebar, and breaking from the same thing. Well, it's up to you.
There was a problem hiding this comment.
Unsure about this still, was an option eventually settled on?
|
I'd appreciate it if we could avoid pasting large screenshots all over this integration thread. Let's keep questions like those to the Discord where we can have a discussion. |
I'll move over to pingin you there then, wasn't sure which you preferred :] |
* feat(lib/mediawiki): use codex style guide to base colour choices * chore(lib/mediawiki): comment nits * fix(lib/mediawiki): change button quiet hover colours to fade accent * fix(mediawiki): remove redundant transparent variables * fix(lib/mediawiki): change tab list framed state colours to latte fade --------- Co-authored-by: uncenter <uncenter@uncenter.dev>
5642232 to
470d1d4
Compare
b8c13fd to
9376d11
Compare
WalkQuackBack
left a comment
There was a problem hiding this comment.
The icons might need another check since Codex Icons has been updated, but I don't have bandwidth to pick it up. Everything else looks good from a cursory review.
|
@ninetailedtori I'm trying to understand where we left of with your requested changes here. Could you summarize what issues, if any, are still present with this pull request's version of the Wikipedia userstyle? Are those issues fixed by #2312? |
|
Honestly after the whole... big merge? I gotta work through it and double check any PRs I was testing re the mediawiki lib 馃ス I'll be checking this one today to see if my comments are still relevant! |

Integrates the new library module for MediaWiki sites from #1866. Must be merged after #1866 is merged into main.