Skip to content

refactor(wikipedia): use mediawiki library module - #1867

Open
uncenter wants to merge 11 commits into
mainfrom
feat/mediawiki-lib-integrate
Open

refactor(wikipedia): use mediawiki library module#1867
uncenter wants to merge 11 commits into
mainfrom
feat/mediawiki-lib-integrate

Conversation

@uncenter

@uncenter uncenter commented Aug 31, 2025

Copy link
Copy Markdown
Member

Integrates the new library module for MediaWiki sites from #1866. Must be merged after #1866 is merged into main.

@github-actions github-actions Bot added the wikipedia Wikipedia label Aug 31, 2025
@uncenter
uncenter force-pushed the feat/mediawiki-lib-module branch from 4741695 to bbffca8 Compare September 3, 2025 22:31
@uncenter
uncenter force-pushed the feat/mediawiki-lib-integrate branch from fda035f to c7a75ec Compare September 3, 2025 22:33
@uncenter
uncenter force-pushed the feat/mediawiki-lib-module branch from bbffca8 to 147fb04 Compare September 7, 2025 22:56
@uncenter
uncenter force-pushed the feat/mediawiki-lib-integrate branch 2 times, most recently from 083513d to b8c13fd Compare September 7, 2025 23:10
@uncenter
uncenter marked this pull request as ready for review September 7, 2025 23:11
@uncenter uncenter linked an issue Oct 11, 2025 that may be closed by this pull request
2 tasks
@uncenter uncenter added 2.status: pending Pending until internal discussion, planned updates, etc. 4.topic: libraries Relating to the standard library and/or library modules labels Nov 4, 2025
@WalkQuackBack WalkQuackBack added the 6.by: staff Authored by a staff member label Nov 4, 2025
@ninetailedtori

Copy link
Copy Markdown
Contributor
image missing this, oddly enough.

@uncenter

uncenter commented Jan 3, 2026

Copy link
Copy Markdown
Member Author

Can you please provide a reproduction URL?

@ninetailedtori

ninetailedtori commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

It seems that because the sidebar content on Help: pages are NOT defined as .infobox maybe? We can see that the content is defined as table.sidebar.sidebar-collapse.nomobile.nowraplinks.hlist.linking-and-page-manipulation with role=navigation, which is different
Yep, confirmed it's a missing .sidebar and .sidebar-collapse tree of formatting that needs to be done in wiki theme directly (it's outside of mw.)

@ninetailedtori ninetailedtori left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add these for some of the meta-page and meta-element theming? :3

Comment thread styles/wikipedia/catppuccin.user.less
@@ -278,7 +117,7 @@
background-color: @surface2;
}

@ninetailedtori ninetailedtori Jan 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}
.sidebar {
background-color: @surface0 !important;
.sidebar-title {
background-color: inherit !important;
}
.sidebar-list-title {
background-color: @surface1 !important;
}
}

Fixes sidebar issue, see Wikipedia contribution Help: pages, e.g. https://en.wikipedia.org/wiki/Help:Interlanguage_links

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there is a specific CSS override for that exact table?

  html.skin-theme-clientpref-night .mw-parser-output .linking-and-page-manipulation {
    background-color:#101418;
    color:white
  }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it's rather consistent for all Help pages, though? Are the others tagged the same as well?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could check yourself that would be great, I'm a little spread thin at the moment.

@ninetailedtori ninetailedtori Jan 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could check yourself that would be great, I'm a little spread thin at the moment.

Confirmed that we need it to be sidebar: see other pages outside of topic: https://en.wikipedia.org/wiki/Wikipedia:Project_namespace#Wikipedia_how-to_and_information_pages, https://en.wikipedia.org/wiki/Wikipedia:Policies_and_guidelines, etc.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, alternatively, [role="navigation"] should be more "specific" if you're worried, as well.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that we need it to be sidebar: see other pages outside of topic: en.wikipedia.org/wiki/Wikipedia:Project_namespace#Wikipedia_how-to_and_information_pages, en.wikipedia.org/wiki/Wikipedia:Policies_and_guidelines, etc.

Those pages use the .help-box class.

Or, alternatively, [role="navigation"] should be more "specific" if you're worried, as well.

I would really like to stick to using the actual classnames on these elements if we could please. There is no need to branch out into attribute selectors here when we can look at how the original CSS does it perfectly well.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to .help-box.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOT certain we should be specifying it with .help-box, tbh. See this: https://en.wikipedia.org/wiki/Wikipedia:Manual_of_Style/Linking#Interwiki_links, where "Manual of Style" sidebar is separate from linking-and-page-manipulation but still sidebar, and breaking from the same thing. Well, it's up to you.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about this still, was an option eventually settled on?

Comment thread styles/wikipedia/catppuccin.user.less
@uncenter

uncenter commented Jan 9, 2026

Copy link
Copy Markdown
Member Author

I'd appreciate it if we could avoid pasting large screenshots all over this integration thread. Let's keep questions like those to the Discord where we can have a discussion.

@ninetailedtori

Copy link
Copy Markdown
Contributor

I'd appreciate it if we could avoid pasting large screenshots all over this integration thread. Let's keep questions like those to the Discord where we can have a discussion.

I'll move over to pingin you there then, wasn't sure which you preferred :]

uncenter and others added 7 commits August 20, 2026 14:51
* feat(lib/mediawiki): use codex style guide to base colour choices

* chore(lib/mediawiki): comment nits

* fix(lib/mediawiki): change button quiet hover colours to fade accent

* fix(mediawiki): remove redundant transparent variables

* fix(lib/mediawiki): change tab list framed state colours to latte fade

---------

Co-authored-by: uncenter <uncenter@uncenter.dev>
@uncenter
uncenter force-pushed the feat/mediawiki-lib-module branch from 5642232 to 470d1d4 Compare August 20, 2026 18:52
@uncenter
uncenter force-pushed the feat/mediawiki-lib-integrate branch from b8c13fd to 9376d11 Compare August 20, 2026 19:04

@WalkQuackBack WalkQuackBack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The icons might need another check since Codex Icons has been updated, but I don't have bandwidth to pick it up. Everything else looks good from a cursory review.

Base automatically changed from feat/mediawiki-lib-module to main August 27, 2026 06:06
@uncenter

Copy link
Copy Markdown
Member Author

@ninetailedtori I'm trying to understand where we left of with your requested changes here. Could you summarize what issues, if any, are still present with this pull request's version of the Wikipedia userstyle? Are those issues fixed by #2312?

@uncenter uncenter removed the 2.status: pending Pending until internal discussion, planned updates, etc. label Aug 31, 2026
@ninetailedtori

Copy link
Copy Markdown
Contributor

Honestly after the whole... big merge? I gotta work through it and double check any PRs I was testing re the mediawiki lib 馃ス I'll be checking this one today to see if my comments are still relevant!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.topic: libraries Relating to the standard library and/or library modules 6.by: staff Authored by a staff member wikipedia Wikipedia

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wikipedia table borders are the same color as background

3 participants