Skip to content

Fixed empty return in top_meta_image - #109

Merged
codelucas merged 1 commit into
codelucas:masterfrom
0x0ece:patch-1
Feb 6, 2015
Merged

Fixed empty return in top_meta_image#109
codelucas merged 1 commit into
codelucas:masterfrom
0x0ece:patch-1

Conversation

@0x0ece

@0x0ece 0x0ece commented Jan 15, 2015

Copy link
Copy Markdown
Contributor

Return empty unicode in ContentExtractor.top_meta_image() when no image is found. It was returning the article's url.

Example:
http://www.usnews.com/news/entertainment/articles/2015/01/15/boyhood-keaton-moore-are-oscar-favorites-in-vegas
(note that USNews often updates its articles, e.g. by adding an image -- at the time of writing it was without images)

Return empty unicode in ContentExtractor.top_meta_image() when no image is found. It was returning the article's url.

Example:
http://www.usnews.com/news/entertainment/articles/2015/01/15/boyhood-keaton-moore-are-oscar-favorites-in-vegas
(note that USNews often updates its articles, e.g. by adding an image -- at the time of writing it was without images)
@codelucas

Copy link
Copy Markdown
Owner

Nicely done, my only comment is that newspaper on master is a python 3 library, so return u'' should be return ''.

Don't worry about it though, I'll merge this on the command line and apply that tiny fix before the code goes in later today.

@0x0ece

0x0ece commented Jan 15, 2015

Copy link
Copy Markdown
Contributor Author

Ops, sorry about that and thank you!

@codelucas
codelucas merged commit e408b86 into codelucas:master Feb 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants