Skip to content

Fixed empty return in top_meta_image #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codelucas merged 1 commit into from
Feb 6, 2015
Merged

Fixed empty return in top_meta_image #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion newspaper/extractors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,9 @@ def get_meta_img_url(self, article_url, doc):

top_meta_image = try_one or try_two or try_three or try_four

return urllib.parse.urljoin(article_url, top_meta_image)
if top_meta_image:
return urllib.parse.urljoin(article_url, top_meta_image)
return u''

def get_meta_type(self, doc):
"""Returns meta type of article, open graph protocol
Expand Down