Skip to content

Original - #30

Merged
codelucas merged 2 commits into
codelucas:masterfrom
otemnov:original
Jan 30, 2014
Merged

Original#30
codelucas merged 2 commits into
codelucas:masterfrom
otemnov:original

Conversation

@otemnov

@otemnov otemnov commented Jan 29, 2014

Copy link
Copy Markdown
Contributor

For otemnov@393601d there could be better solution related to config refactor. Kept it simple for now

@codelucas

Copy link
Copy Markdown
Owner

Looks good, thank you! I will merge by tonight.

Can you explain your addition of the ValueError er exception?

@otemnov

otemnov commented Jan 30, 2014

Copy link
Copy Markdown
Contributor Author

I tried to parse following article http://ajaxian.com/archives/mobile-proxies-a-new-era-dawns
It contains following url in images collection http://technorati.com/favicon.ico
Maybe it is just an issue with my version of Pillow, but it was not able to process this image - fails with ValueError

@codelucas

Copy link
Copy Markdown
Owner

I see, merged. Thanks for the PR once again.

codelucas added a commit that referenced this pull request Jan 30, 2014
@codelucas
codelucas merged commit b78529f into codelucas:master Jan 30, 2014
@codelucas

Copy link
Copy Markdown
Owner

I added one more tiny fix after merging. 16/9 in python yields the integer 1 instead of what we want (1.77).

5053056

@otemnov

otemnov commented Jan 30, 2014

Copy link
Copy Markdown
Contributor Author

aha, thank you! Just switched from NodeJS :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants