Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions newspaper/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ def __init__(self):

# set this to false if you don't care about getting images
self.fetch_images = True
self.image_dimension_ration = 16/9

# don't toggle this variable
self.use_meta_language = True
Expand Down
3 changes: 1 addition & 2 deletions newspaper/extractors.py
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,7 @@ def get_img_urls(self, article):
"""
doc = article.raw_doc
urls = self.parser.get_img_urls(doc)
img_links = [ urlparse.urljoin(article.url, url) for url in urls ]

img_links = set([ urlparse.urljoin(article.url, url) for url in urls ])
return img_links

def get_top_img_url(self, article):
Expand Down
6 changes: 5 additions & 1 deletion newspaper/images.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,10 @@ def fetch_url(url, useragent, referer=None, retries=1, dimension=False):
'installation this machine: %s' % str(e))
p = None
break
except ValueError, ve:
log.debug('cant read image format: %s' % url)
p = None
break
new_data = open_req.read(chunk_size)
content += new_data

Expand Down Expand Up @@ -189,7 +193,7 @@ def largest_image_url(self):
continue

# ignore excessively long/wide images
if max(size) / min(size) > 1.5:
if max(size) / min(size) > self.config.image_dimension_ration:
log.debug('ignore dims %s' % img_url)
continue

Expand Down