Add tooling utils - #15
Closed
jcbhmr wants to merge 9 commits into
Closed
Conversation
Contributor
|
Is there any reason why we can't wait for devcontainers/spec#209 to be implemented in the CLI? |
Member
Author
no reason whatsoever! if we can wait until then, that's less work for me 👍 |
Contributor
|
I do not think it is worthwhile to deviate from the standard workflow to implement this. |
Member
Author
|
sounds like a plan! 🚀 should i just copy the two script into the src/id/utils folder manually for now then? 🤔 # shellcheck shell=bash
clear_local_apt_index() (
set -e
rm -rf /var/lib/apt/lists/*
echo '🟩 Cleared local apt index'
)
# shellcheck shell=bash
ensure_apt_packages() (
set -e
export DEBIAN_FRONTEND=noninteractive
if dpkg -s "$@" &>/dev/null; then
echo "🟦 $@ is already installed"
else
if [[ $(find /var/lib/apt/lists/* | wc -l) == 0 ]]; then
echo '🟪 Updating local apt index...'
apt-get update -y
echo '🟩 Updated local apt index'
fi
echo "🟪 Installing $@..."
apt-get install -y --no-install-recommends "$@"
echo "🟩 Installed $@"
fi
)
|
jcbhmr
added a commit
that referenced
this pull request
May 1, 2023
Contributor
|
I think manual copying is best at this time. I would prefer not to split scripts for functions of that length. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR would...
devcontainer features testif the proposal to make shared stuff is already here, then this is redundant! yay! 🥳
devcontainers/spec#209
it just needs to be implemented in the cli... until then, we're stuck doing the
cp utils src/$ID/utilsmanually 🤷♀️