Skip to content

Create LLVM feature - #16

Closed
jcbhmr wants to merge 8 commits into
mainfrom
add-llvm
Closed

Create LLVM feature#16
jcbhmr wants to merge 8 commits into
mainfrom
add-llvm

Conversation

@jcbhmr

@jcbhmr jcbhmr commented May 1, 2023

Copy link
Copy Markdown
Member

鈿狅笍 based on #15's branch!

This is a feature that I've had in my own feature repository under @jcbhmr for a while, and I think it's a reasonably widespread tool and might be worth adopting into this @devcontainers-community organization? If we aren't ready to actually do features yet @eitsupi I can continue housing this under my @jcbhmr feature repo.

This PR would...

  • Create a VERY basic LLVM feature
  • Use the official installer
  • Have comments in the code to attempt to explain what's happening and why. Shell scripts can get complicated!

@jcbhmr jcbhmr added the enhancement New feature or request label May 1, 2023
@jcbhmr jcbhmr self-assigned this May 1, 2023
@eitsupi

eitsupi commented May 1, 2023

Copy link
Copy Markdown
Contributor

I think anything should not be added at this point as there are no acceptance criteria for this repository.

For example, there are clear criteria in linguist that control the language that GitHub recognizes. We need to determine such criteria.
https://github.com/github-linguist/linguist/blob/master/CONTRIBUTING.md#adding-an-extension-to-a-language

@jcbhmr

jcbhmr commented May 1, 2023

Copy link
Copy Markdown
Member Author

@eitsupi Good idea! Will do. 馃殌

@jcbhmr jcbhmr mentioned this pull request May 1, 2023
@jcbhmr jcbhmr added this to the First feature milestone May 1, 2023
@jcbhmr jcbhmr mentioned this pull request May 2, 2023
6 tasks
@jcbhmr jcbhmr closed this May 2, 2023
@eitsupi
eitsupi deleted the add-llvm branch May 2, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants